[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#254601: XFree refusees to start with sis video card, complains about unresolved symbols



Branden Robinson wrote:
> On Thu, Jun 17, 2004 at 06:22:16PM +0200, Thomas Winischhofer wrote:
>> I just enhanced/fixed this in the driver available on my website
>> (06/17). It now loads the glx module if that hasn't been loaded
>> before.
>> Hence, it does not matter if Load "dri" and/or Load "glx" are in the
>> Module section. Unless option "DRI" is set to "off", the driver will
>> load both.
>
> So, in your opinion, is this bug:
>
> A) due to user error?
> B) due to a driver bug that is fixed in the 2004-06-17 edition of your
>    driver?
> C) something else?

Sorry for the late answer, I missed this message.

Well, I think it is an error in the whole configuration concept of dri, glx and GLcore.

The "dri" module, for what reasons ever, depends on the glx module (for some symbols).

Previously (around 4.3 and before), the SiS driver itself did not load the dri module but checked if it was available by checking if a canonical symbol is found. Disabling DRI was then done by commenting Load "dri" in the Module-section. If the symbol wasn't found, the DRI initialisation was skipped.

This policy was slightly changed last year (don't ask me when exactly) where a number of drivers were changed (by David Dawes, IIRC) to load the "dri" module by themselves. However, none loads "glx". The consequence is that if the driver loads "dri" and the "Load "glx"" statement is missing in the Module-section, the server complains about unresolved symbols.

The driver currently in Debian's XFree86 packages only loads "dri" and, consequently, REQUIRES the

	Load "glx"

statement in the Module-section (unless the Option "DRI" is set to "off", in which case the driver will not load the "dri" module.)

The current SiS driver (from my website as well as in X.org and XFree86 CVS) circumvents this situation by explicitely loading the "glx" module as well in case DRI is to be used.

Hence:

While disabling/enabling DRI previously was done by commenting/uncommenting the "Load "dri"" statement in the Module-section, this is now done by a dedicated "DRI" option (to be placed in the Device-section).

	Option "DRI" "off"

disables DRI (and skips loading "dri" and "glx").

So, perhaps you can yourself classify the quality of this misbehavior according to your three options ;)

Thomas

--
Thomas Winischhofer
Vienna/Austria
thomas AT winischhofer DOT net	       *** http://www.winischhofer.net
twini AT xfree86 DOT org



Reply to: