On Sat, May 01, 2004 at 07:18:01PM +0200, Christoph Hellwig wrote: > On Sat, May 01, 2004 at 12:10:03PM -0500, X Strike Force SVN Repository Admin wrote: > > +@@ -58,7 +58,7 @@ > > + #ifdef _LP64 > > + # if defined(__sparcv9) > > + # define _MACH64_NAME "sparcv9" > > +-# elif defined(__ia64__) > > ++# elif defined(__ia64__) || defined(__amd64__) > > + # undef MACH64_NAME > > + # else > > + # error "Unknown architecture" > > Shouldn't this simply be: > > #if defined(_LP64) && defined(__sparcv9) > # define _MACH64_NAME "sparcv9" > #else > # undef _MACH64_NAME > #endif > > else you'll have to add to the negative list for every new architecture > that defines _LP64.. Probably, yes. I also find usage of the symbol _MACH64_NAME vastly confusing. It took me a long time to figure out that David S. Miller, or whoever wrote that patch originally, wasn't talking about ATI Mach64 video chipsets, which confused the hell out of as such stuff has no place in that part of Xlib. -- G. Branden Robinson | One man's "magic" is another man's Debian GNU/Linux | engineering. "Supernatural" is a branden@debian.org | null word. http://people.debian.org/~branden/ | -- Robert Heinlein
Attachment:
signature.asc
Description: Digital signature