[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#226365: selection-method question should not be displayed at high priority



On Thu, Jan 08, 2004 at 08:16:45PM -0500, Joey Hess wrote:
> Branden Robinson wrote:
> > So I stand by my decision that this question needs to be high priority
> > under *some* circumstances.  Naturally I'm interested in minimizing
> > those.
> 
> What do you think about skipping the question about what configuration
> method to use for X if the debconf priority is already high. Default it
> to medium if simple is not a good choice.

Please tell me what you think of the following:

  # priority of xserver-xfree86/config/monitor/selection-method
  set_db_priority "medium"

  if [ -n "$HORIZ_SYNC" ] && [ -n "$VERT_REFRESH" ]; then
    observe "\$HORIZ_SYNC: \"$HORIZ_SYNC\" ; \$VERT_REFRESH:" \
            "\"$VERT_REFRESH\"; setting question priority to low"
    set_db_priority "low"
  else
    observe "at least of one of hsync \"$HORIZ_SYNC\" or vrefresh" \
            "\"$VERT_REFRESH\" is null; not setting question priority to low"
  fi

  observe "monitor hsync and vrefresh question priority is $PRIORITY"

  auto_answer db_input "$PRIORITY" \
    xserver-xfree86/config/monitor/lcd "false"
  db_get xserver-xfree86/config/monitor/lcd
  observe "xserver-xfree86/config/monitor/lcd is $RET"
  MONITOR_IS_LCD="$RET"
  if [ "$RET" = "true" ]; then
    db_subst xserver-xfree86/config/monitor/selection-method choices \
      "Medium, Advanced"
  else # not an LCD
    db_subst xserver-xfree86/config/monitor/selection-method choices \
      "Simple, Medium, Advanced"
  fi

  # Flat panels are more and more common, so set the default to medium.
  db_subst xserver-xfree86/config/monitor/selection-method default "Medium"

  run db_input "$PRIORITY" xserver-xfree86/config/monitor/selection-method

  # priority of xserver-xfree86/config/monitor/{several things}
  set_db_priority "high"
[...]

-- 
G. Branden Robinson                |       Our ignorance is God; what we
Debian GNU/Linux                   |       know is science.
branden@debian.org                 |       -- Robert Green Ingersoll
http://people.debian.org/~branden/ |

Attachment: signature.asc
Description: Digital signature


Reply to: