retitle 236334 xserver-xfree86: [i810] driver needs better agpgart error message for Linux 2.6 users severity 236334 minor tag 236334 + upstream patch thanks On Sat, Mar 06, 2004 at 10:01:50PM +0100, Christian Guggenberger wrote: > On Sat, 2004-03-06 at 21:28, Jason Dorje Short wrote: > > I mean the error messages from my original report. They say "make sure > > your kernel is using the agpgart module", when in fact the kernel is > > using this module and the problem is that's not enough. A better > > message might be something like "make sure your kernel is using the > > agpgart module. Under kernel 2.6 and higher, you'll need to use a > > chipset-specific AGP module as well." This would have been sufficient > > for me to find and fix the problem on my own. > > > That's a good idea, isn't it? > Branden, what do think? > Is it possible to include this in Xfree86 sources, or would it be safer, > to just put it in Debian's X faq ? People don't read the FAQ. Better to improve the driver's error message. Any comments on the attached patch? It would be nice if someone would apply this patch and test it -- as you'll recall, I don't have easy access to an x86 box for build testing. -- G. Branden Robinson | Kissing girls is a goodness. It is Debian GNU/Linux | a growing closer. It beats the branden@debian.org | hell out of card games. http://people.debian.org/~branden/ | -- Robert Heinlein
--- xc/programs/Xserver/hw/xfree86/drivers/i810/i810_driver.c~ 2004-03-08 16:13:55.000000000 -0500
+++ xc/programs/Xserver/hw/xfree86/drivers/i810/i810_driver.c 2004-03-08 16:18:39.000000000 -0500
@@ -802,8 +802,11 @@
*/
if (!xf86AgpGARTSupported()) {
xf86DrvMsg(pScrn->scrnIndex, X_ERROR,
- "AGP GART support is not available. Make sure your kernel has\n"
- "\tagpgart support or that the agpgart kernel module is loaded.\n");
+ "AGP GART support is not available. Make sure your kernel\n"
+ "\thas agpgart support built-in or that the agpgart kernel\n"
+ "\tmodule is loaded. Users of Linux 2.6 or later should\n"
+ "\talso ensure that chipset-specific AGP support is\n"
+ "\tbuilt-in, or the corresponding module loaded.\n");
return FALSE;
}
Attachment:
signature.asc
Description: Digital signature