[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#217605: Reopen 217605



On Sun, Nov 16, 2003 at 09:49:21AM +0100, Denis Barbier wrote:
> reopen 217605
> tag 217605 = patch
> thanks
> 
> Hi,
> 
> the fix is wrong:
>   * In xdm.config, because of a typo when calling head, CURRENT_DEFAULT is
>     empty, so at end of script $DEFAULT_DISPLAY_MANAGER_FILE is moved to
>     $DEFAULT_DISPLAY_MANAGER_FILE.dpkg-tmp

Thanks for catching this.

>   * In xdm.postinst, as $DEFAULT_DISPLAY_MANAGER_FILE does not exist,
>     the debconf stuff is always run.  If $DEFAULT_DISPLAY_MANAGER/daemon_name
>     does not exist, DAEMON_NAME contains
>       "10 $DEFAULT_DISPLAY_MANAGER/daemon_name doesn't exist"
>     or something like that.  This is because of your safe_debconf
>     function, it is not safe at all ;o)
>     You must instead test db_get return code, which makes safe_debconf
>     pretty useless, so I removed calls to it from both scripts.

I think you got too carried away with killing off my usage of
safe_debconf.

-- 
G. Branden Robinson                |    A committee is a life form with six
Debian GNU/Linux                   |    or more legs and no brain.
branden@debian.org                 |    -- Robert Heinlein
http://people.debian.org/~branden/ |

Attachment: signature.asc
Description: Digital signature


Reply to: