On Thu, Oct 23, 2003 at 04:48:52PM +0200, Robert Millan wrote: > > Why is the source file > > xc/programs/Xserver/hw/xfree86/drivers/i810/i830_driver.c being dealt > > with at all when NOT_BUILDING_X_SERVER is defined? > > I don't know, what I remember is that the error happened only when building > xserver-xfree86-dbg, not the standard xc dir. That's because when the linker puts the X server and all its modules together into one huge object, it can see failed symbol resolutions that aren't evident when the modules are kept separate. > > (Oh, I get it. You're using NOT_BUILDING_X_SERVER prescriptively, by > > defining it when you run debian/rules or something similar, not > > descriptively. I'm not sure that's a good idea. If I'd meant > > NOT_BUILDING_X_SERVER to be used prescriptively, I'd have called it > > DO_NOT_BUILD_X_SERVER.) > > I exported it as an environmental variable, before running dpkg-buildpackage. I > wasn't aware there was other method, though. What is it? Don't set that. Fix the bug (which I think you did), or edit the appropriate file for the OS in xc/config/cf to turn off X server building. See the s390 area of linux.cf for an example. As I said, NOT_BUILDING_X_SERVER is *descriptive*, not *prescriptive*. Setting it doesn't affect the actual build of upstream sources in any way. > The bug in i830_driver.c is clear though, if you look at the patched file > with context: > > #ifdef XF86DRI > I830Ptr pI830 = I830PTR(pScrn); > #endif > [...] > /* NeedToSync is set TRUE in RefreshRing called from ResetState() */ > pI830->AccelInfoRec->NeedToSync = FALSE; > > This code will break if ever compiled without the XF86DRI macro. Yeah, this is clear. > > Either way, we need to come up with a better commit log and changelog > > entry. Your description of the error is not meaningful in the context > > of the XFree86 build itself. > > Ok. What else should the description say? It should probably say what it does but stop talking about NOT_BUILDING_X_SERVER stuff. -- G. Branden Robinson | I must despise the world which does Debian GNU/Linux | not know that music is a higher branden@debian.org | revelation than all wisdom and http://people.debian.org/~branden/ | philosophy. -- Ludwig van Beethoven
Attachment:
signature.asc
Description: Digital signature