[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#191463: xlibs: [libXi] calls LockDisplay() before _XiCheckExtInit() instead of after



Package: xlibs
Version: 4.2.1-6
Severity: normal
Tags: upstream

Report MIME-attached.

-- 
G. Branden Robinson                |    Men use thought only to justify
Debian GNU/Linux                   |    their wrong doings, and speech only
branden@debian.org                 |    to conceal their thoughts.
http://people.debian.org/~branden/ |    -- Voltaire
--- Begin Message ---
Heya,

This is a fix for http://bugzilla.gnome.org/show_bug.cgi?id=111349
It's a bug in libXi that has been around for a long long time.

While this bug is present, Totem[1] is unusable.
Patch attached below.

Tested and approved :)

[1]: http://www.hadess.net/totem.php3
-- 
/Bastien Nocera
http://www.redhat.com

Perfection is reached, not when there is no longer anything to add, but
when there is no longer anything to take away.
                                                Antoine de Saint-Exupery
--- xc/lib/Xi/XListDev.c.orig	2003-04-30 02:40:02.000000000 -0400
+++ xc/lib/Xi/XListDev.c	2003-04-30 02:40:27.000000000 -0400
@@ -81,10 +81,10 @@
     register long 		rlen;
     XExtDisplayInfo *info = XInput_find_display (dpy);
 
-    LockDisplay (dpy);
     if (_XiCheckExtInit(dpy, XInput_Initial_Release) == -1)
 	return ((XDeviceInfo *) NULL);
 
+    LockDisplay (dpy);
     GetReq(ListInputDevices,req);		
     req->reqType = info->codes->major_opcode;
     req->ReqType = X_ListInputDevices;

--- End Message ---

Attachment: pgpSDkfx81JO7.pgp
Description: PGP signature


Reply to: