Bug#179156: marked as done (xserver-common: Xwrapper incorrectly reports nice values.)
Your message dated Fri, 31 Jan 2003 11:30:24 -0500
with message-id <20030131163024.GU28323@deadbeast.net>
and subject line Bug#179156: xserver-common: Xwrapper incorrectly reports nice values.
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 31 Jan 2003 07:35:52 +0000
>From evanb@cats.ucsc.edu Fri Jan 31 01:35:52 2003
Return-path: <evanb@cats.ucsc.edu>
Received: from adsl-64-161-212-85.dsl.snfc21.pacbell.net (heron) [64.161.212.85]
by master.debian.org with esmtp (Exim 3.12 1 (Debian))
id 18eViJ-0007l4-00; Fri, 31 Jan 2003 01:35:52 -0600
Received: from evanb by heron with local (Exim 3.35 #1 (Debian))
id 18eVZO-0001Ua-00; Thu, 30 Jan 2003 23:26:55 -0800
From: Evan Buswell <evanb@cats.ucsc.edu>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: xserver-common: Xwrapper incorrectly reports nice values.
X-Mailer: reportbug 1.50
Date: Thu, 30 Jan 2003 23:26:38 -0800
Message-Id: <[🔎] E18eVZO-0001Ua-00@heron>
Sender: Evan <evanb@cats.ucsc.edu>
Delivered-To: submit@bugs.debian.org
X-Spam-Status: No, hits=-0.5 required=5.0
tests=PATCH_UNIFIED_DIFF,PGP_SIGNATURE,SPAM_PHRASE_00_01
version=2.41
X-Spam-Level:
Package: xserver-common
Version: 4.1.0-16
Severity: minor
Tags: patch
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
this fixes a minor cosmetic bug: the xserver reports "process set to
nice value 0 instead of XXX" when in fact the server *was* set to the
correct values. This happens because "nice" in linux does not return
the nice value set, but instead returns 0.
- -- System Information
Debian Release: 3.0
Architecture: i386
Kernel: Linux heron 2.4.18-lsm #1 Sun Jan 19 10:50:03 PST 2003 i686
Locale: LANG=C, LC_CTYPE=C
Versions of packages xserver-common depends on:
ii debconf 1.0.32 Debian configuration management sy
ii libc6 2.2.5-11.2 GNU C Library: Shared libraries an
ii xfree86-common 4.1.0-16 X Window System (XFree86) infrastr
- --------patch is below this line--------------------------
- --- xserver-wrapper.c Thu Jan 30 23:02:32 2003
+++ xserver-wrapper.c.new Thu Jan 30 23:10:07 2003
@@ -53,6 +53,8 @@
* specify "-help" option to get a usage message (26 Dec 2001)
* Branden Robinson: change nice() usage to fit SuSv2 semantics; see Debian Bug
* #140012
+ * Evan Buswell: use getpriority to get nice value; return value of "nice"
+ * is 0 on success.
*
* This is free software; you may redistribute it and/or modify
* it under the terms of the GNU General Public License as
@@ -83,6 +85,8 @@
#include <unistd.h>
#include <sys/stat.h>
#include <sys/types.h>
+#include <sys/time.h>
+#include <sys/resource.h>
#define VT_MAJOR_DEV 4
#define X_WRAPPER_CONFIG_FILE "/etc/X11/Xwrapper.config"
@@ -276,8 +281,9 @@
seteuid(0);
/* DEBUG fprintf(stderr, "X: attempting nice() with real uid = %d; euid = %d\n", getuid(), geteuid()); */
errno = 0;
- - intval = nice(niceval);
+ nice(niceval);
if (errno) perror("X: warning; nice() of process failed");
+ intval = getpriority(PRIO_PROCESS, 0);
if (intval != niceval) (void) fprintf(stderr, "warning: process set to nice "
"value %d instead of %d as requested\n", intval, niceval);
/* DEBUG exit(0); */
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org
iD8DBQE+OiU/YHF64J1lpdoRAhFyAKCnktMTDqTI5Mn+HerYSy4CwuLfgwCcCQex
sOi1TRX5a73ElQj/1YUOmzA=
=9ozg
-----END PGP SIGNATURE-----
---------------------------------------
Received: (at 179156-done) by bugs.debian.org; 31 Jan 2003 16:30:28 +0000
>From branden@deadbeast.net Fri Jan 31 10:30:27 2003
Return-path: <branden@deadbeast.net>
Received: from dhcp16621067.indy.rr.com (redwald.deadbeast.net) [24.166.21.67]
by master.debian.org with esmtp (Exim 3.12 1 (Debian))
id 18ee3e-000504-00; Fri, 31 Jan 2003 10:30:26 -0600
Received: by redwald.deadbeast.net (Postfix, from userid 1000)
id 0DAFC640AC; Fri, 31 Jan 2003 11:30:24 -0500 (EST)
Date: Fri, 31 Jan 2003 11:30:24 -0500
From: Branden Robinson <branden@debian.org>
To: 179156-done@bugs.debian.org
Subject: Re: Bug#179156: xserver-common: Xwrapper incorrectly reports nice values.
Message-ID: <20030131163024.GU28323@deadbeast.net>
References: <[🔎] E18eVZO-0001Ua-00@heron>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
protocol="application/pgp-signature"; boundary="udzYTtuEmHLUHegf"
Content-Disposition: inline
In-Reply-To: <[🔎] E18eVZO-0001Ua-00@heron>
User-Agent: Mutt/1.5.3i
Delivered-To: 179156-done@bugs.debian.org
X-Spam-Status: No, hits=-15.2 required=5.0
tests=IN_REP_TO,PGP_SIGNATURE_2,QUOTED_EMAIL_TEXT,REFERENCES,
SPAM_PHRASE_00_01,USER_AGENT,USER_AGENT_MUTT
version=2.41
X-Spam-Level:
--udzYTtuEmHLUHegf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Thu, Jan 30, 2003 at 11:26:38PM -0800, Evan Buswell wrote:
> Package: xserver-common
> Version: 4.1.0-16
> Severity: minor
> Tags: patch
[...]
> this fixes a minor cosmetic bug: the xserver reports "process set to
> nice value 0 instead of XXX" when in fact the server *was* set to the
> correct values. This happens because "nice" in linux does not return
> the nice value set, but instead returns 0.
This was already fixed, way back in 4.1.0-17.
Closing this report.
--=20
G. Branden Robinson | "To be is to do" -- Plato
Debian GNU/Linux | "To do is to be" -- Aristotle
branden@debian.org | "Do be do be do" -- Sinatra
http://people.debian.org/~branden/ |
--udzYTtuEmHLUHegf
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
iEYEARECAAYFAj46pKAACgkQ6kxmHytGonwiOgCdEG+VviQdPq7jRSG6OjttYySg
Q/QAoICRUlZQr22WnzYiseenBMHj/dM7
=7OPo
-----END PGP SIGNATURE-----
--udzYTtuEmHLUHegf--
Reply to: