[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#177369: xfs: blanks added to end of syslog lines -- wasteful



On Sun, Jan 19, 2003 at 07:09:57AM +0800, Dan Jacobson wrote:
> wasteful blanks found:
> 
> for i in ' ' '  ' '   ';do echo '|||||||||';grep "$i"\$ /var/log/syslog.0;done|\
> grep xfs|sort -u;false
> Jan 18 16:27:08 debian xfs[456]: terminating 
> Jan 19 05:43:52 debian xfs: ignoring font path element /usr/lib/X11/fonts/cyrillic/ (unreadable) 
> Jan 19 05:43:53 debian xfs: ignoring font path element /usr/lib/X11/fonts/CID (unreadable) 

If you, or someone reading this report on debian-x, would like to get
into XFree86 source hacking in a gentle way, here's a pointer to where
and what needs to be fixed:

[0] branden@redwald:~/packages/xfree86 % grep -r terminating xc/programs/xfs/*
xc/programs/xfs/difs/dispatch.c:                NoticeF("terminating\n");
[0] branden@redwald:~/packages/xfree86 % grep -r unreadable xc/programs/xfs/*
xc/programs/xfs/difs/fonts.c:           NoticeF("ignoring font path element %s (unreadable)\n", fpe->name);

My guess is those explicit newlines don't need to be passed to
NoticeF().

Extra points for merging a patch for the above into patch #003.

Otherwise, I'll get to it when I can.  There are some major changes
planned for 4.2.1-6, so this will take a back seat to those.

-- 
G. Branden Robinson                |     Don't use nuclear weapons to
Debian GNU/Linux                   |     troubleshoot faults.
branden@debian.org                 |     -- US Air Force Instruction 91-111
http://people.debian.org/~branden/ |

Attachment: pgpGBP2MEil5F.pgp
Description: PGP signature


Reply to: