[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH for 0pre1v3] r128 and radeon without vgaHW problem fix

On Sam, 2002-08-31 at 19:24, ISHIKAWA Mutsumi wrote:
> >>  Hmm, I understand the problem.
> >>
> >>  radeon_drv and r128_drv require some vga related functions, defined
> >> in xc/programs/Xserver/hw/xfree86/vgahw/vgaHW.{c,h}. But on SPARC
> >> environment vgaHW.c will not build because SPARC machines does not
> >> have VGA, so XF86VgaHw is set as NO.
> >>
> >>  Under build-tree/xc-xserver-xfree86-dbg, we will build the static
> >> linked x server. Symbols are resolved on build time.
> >>
> >>  Perhaps, we should drop r128 and radeon driver support when the x
> >> server build without XF86VgaHw define.
> >> (or r128 and radeon drivers should update to be able to build and run
> >> without vgaHW).
>  I put a patch to build fix on SPARC and new MANIFEST.sparc.
> http://people.debian.org/~ishikawa/XFree86/4.2.0-0pre1v3/sparc/101_sparc_ati_without_vgahw.diff

This is a bad patch IMHO. Almost every driver uses vgaHW, how are the
others handled on sparc?

I see a number of better solutions:

- guard the vgaHW calls in the drivers
- build/fix/implement vgaHW on sparc (no, it doesn't require legacy
- ...

Earthling Michel Dänzer (MrCooper)/ Debian GNU/Linux (powerpc) developer
XFree86 and DRI project member   /  CS student, Free Software enthusiast

Reply to: