Re: xfree86-1_3.3.4 now compiles on powerpc, mach64 mess fixed, patch included.

[Ben Collins <bcollins@debian.org>]

On Thu, Sep 23, 1999 at 02:54:51PM +0200, Sven LUTHER wrote:
> On Thu, Sep 23, 1999 at 08:46:41AM -0400, Ben Collins wrote:
> > On Thu, Sep 23, 1999 at 02:40:34PM +0200, Sven LUTHER wrote:
> > > > 
> > > > I never said it needed to be rejected, I just said add #if's around it, which was
> > > > contructive and solved both problems. You cannot have it in regmach64.h even with
> > > > the #if's around it for sparc, I tried it and it wont pick it up for some reason.
> > > 
> > > Maybe it would be better to solve that problem. regmach64.h is included from
> > > mach64.h i think, into mach64im.c.
> > 
> > The problem is that regmach64.h should be regmach64.c (as it was orignally coded)
> > but for some reason it has been patched up this way. Atleast this is my take on it.
> > With all the macros and defines across several includes, mac64im.c just wont pick
> > it up for sparc.
> > 
> > > There is an #ifdef FBDEV around the whole regxxx stuff. Do you build an fbdev
> > > server on sparc or a normal one ? There should be no reason it don't works.
> > 
> > No, it's a normal server.
> 
> Ok, that explains thing, since the regmach64.h stuff has a #ifdef FBDEV server
> around it. Could you please try the patch i sent to this list ? It should
> provide a solution for this. It is quite hacky yet, but i would like to know if
> it works. Basicaly i put a #elif defined (__sparc__) after the #ifdef
> FBDEV_server which contains a copy of the regwbe function. So it should also
> get included on the non fbdev sparc built.

How about moving that whole function out of the FBDEV_server block and setup it up
like:

#if defined(FBDEV_server) || defined(__sparc__)
.....
#endif

This way it only needs to be listed once.

> I will write also to the Xfree list to see whåt is the common opinion on this
> stuff, and see to it that it is handled in a nice way. BTW, did you try the
> 3.9.x servers on sparc ? 

Not yet, I have been busy with a few other things.

Ben