[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1019872: marked as done (remove unused scripts)



Your message dated Mon, 02 Oct 2023 21:02:37 +0000
with message-id <651b2fed40e24_25e19d96054292@godard.mail>
and subject line Bug#1019872 fixed in www.debian.org
has caused the Debian Bug report #1019872,
regarding remove unused scripts
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1019872: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1019872
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: www.debian.org
Severity: normal


On IRC we had a discussion if the script
english/devel/website/stats/anoncvs-cors is still used. It seems that
more parts concerning the translations stats are not needed any more.



< Mrfai> Is this script used anywere:
english/devel/website/stats/anoncvs-cors ? I cannot find anything and would like to remove it
< Mrfai> There's only a link to http://webwml.alioth.debian.org/cgi-bin/anoncvs-cors in diffstat.js but I think this function is not used any more.
< pabs> `git grep` says stattrans.pl emits calls to setDiffstat in the onClick attribute of a <span> tag
< pabs> Mrfai: I think the onclick=setDiffstat can probably just be replaced with <a href= to salsa commit pages
< pabs> or maybe the compare URLs 
< pabs> hmm, it wants diffstats not full patches...
< pabs> if the exact functionality is still wanted, then maybe the script could migrate to cgi.debian.org
< pabs> probably best to ask debian-i18n if the diffstat is useful
< Mrfai> pabs: But I cannot find any reference of this onlick in the html files.
< Mrfai> I did this:
< Mrfai> ...@wolkenstein:/srv/www.debian.org/www/international$ grep -r setDiffstat .
< Mrfai> And it found nothing
< pabs> I'm looking at stattrans again
< pabs> hmm, the Diffstat column is definitely present https://www.debian.org/devel/website/stats/en
< pabs> seems the diffstat link is only shown if "!defined $status_db{$lang}"
< pabs> which looks like the english/international/l10n/data/status.* files
< pabs> seems english/international/l10n/scripts/gen-files.pl creates those files
< pabs> those files do exist on wolkenstein
< pabs> they are symlinks to /srv/www.debian.org/cron/datafiles/status.*
< pabs> Sledge's a3fcc21a7c098056a557a095178aee9f752d6059 deleted a previous use of diffstat stuff, adding git command-lines instead, so it sounds like the web team 
                            wants translators to manually do diffstats themselves, so I guess delete the diffstat column and all the supporting infrastructure

--- End Message ---
--- Begin Message ---
Hello,

Bug #1019872 in www.debian.org reported by you has been fixed in the Git repository.
You can see the commit message below and you can check the diff of the fix at:

https://salsa.debian.org/webmaster-team/webwml/-/commit/a7230c87f8a94017b17ed71b668fe7ab0c419433

------------------------------------------------------------------------
remove unused script, closes: #1019872
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/1019872

--- End Message ---

Reply to: