[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#851458: marked as done (not-enough-i18n'ed string on devel/website/stats/ pages)

Your message dated Fri, 10 Feb 2017 20:13:53 +0000
with message-id <E1ccHZp-0003Fz-Qu@moszumanska.debian.org>
and subject line Debian WWW CVS commit by larjona fixes #851458
has caused the Debian Bug report #851458,
regarding not-enough-i18n'ed string on devel/website/stats/ pages
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
851458: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=851458
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: www.debian.org
Severity: wishlist
Tags: patch l10n

I-have-known-since-5-years-ago bug, though, 
on current devel/website/stats/ pages,
a gettext string is not enough i18n'ed as it does not include its object;

w/ the patch applied, the string will become like
 "Created with <trasstatslink>"
instead of
 "Created with"
so we can translate it as
 "<trasstatslink> により生成しました"

patch below

Index: stattrans.pl
===================================================================
--- stattrans.pl	(revision 240)
+++ stattrans.pl	(working copy)
@@ -535,6 +535,11 @@
         if (open (HTML, ">$config{'htmldir'}/$l.wml")) {
 	    printf HTML "#use wml::debian::template title=\"<:=\$trans{\$CUR_ISO_LANG}{%s}:>\"\n", $lang;
 	    print HTML "#use wml::debian::toc\n";
+printf HTML qq|<define-tag trasstatslink><a href="%s">webwml-stattrans</a></define-tag>\n|,
+		alioth_cvs_view_url('stattrans.pl');
+printf HTML "<define-tag createdwith><address>\n";
+printf HTML "<gettext domain=\"stats\">Created with <trasstatslink></gettext>\n"
+printf HTML "</address></define-tag>\n";
             print HTML "<script src=\"diffstat.js\" type=\"text/javascript\"></script>\n\n";
             $color = get_color ($percent_a{$lang});
 
@@ -655,10 +660,7 @@
                 print HTML "</table>\n";
             }
 
-            print HTML
-                '<address><gettext domain="stats">Created with</gettext> <a href="'
-                . alioth_cvs_view_url('stattrans.pl')
-                . '">webwml-stattrans</a></address>' . "\n";
+            print HTML "<createdwith>\n";
             close (HTML);
         } else {
             print "Can't open $config{'htmldir'}/$l.wml\n";
@@ -809,10 +811,7 @@
 print HTMLI "</tbody>";
 print HTMLI "</table>\n";
 
-print HTMLI
-    '<address><gettext domain="stats">Created with</gettext> <a href="'
-    . alioth_cvs_view_url('stattrans.pl')
-    . '">webwml-stattrans</a></address>' . "\n";
+print HTMLI "<createdwith>\n";
 close (HTMLI);
 
 print "done.\n" if ($config{'verbose'});


-- 
victory
no need to CC me :-)

--- End Message ---
--- Begin Message --- 
This bug was closed by larjona in the webwml CVS repository:

https://www.debian.org/devel/website/using_cvs

Note that it might take some time until www.debian.org has been updated.

CVSROOT:	/cvs/webwml
Module name:	webwml
Changes by:	larjona	17/02/10 20:13:53

Modified files:
	.              : stattrans.pl 

Log message:
	Better i18n for "Created with stattrans" string. Thanks Victory for the patch. Closes: #851458

--- End Message ---
Reply to: