Bug#815239: www.debian.org: improving package search forms to be more intuitive

[Stéphane Blondon <stephane.blondon@gmail.com>]

Package: www.debian.org
Severity: normal
Tags: patch


The search forms at https://www.debian.org/distrib/packages.en.html have
the submit button in the first line.
I think it's surprising for a newcomer and providing the submit button
at the end for the form fits probably better to visitor's mind. The
attached search_form.png shows the difference of paths required to the
visitor.

For the same reason, an input is under another one for each forms.

The patches are based on the files found in the CVS repository.


-- 
Stéphane

Attachment: search_form.png
Description: PNG image

--- search_contents-form.inc.orig	2016-02-20 03:24:31.000000000 +0100
+++ search_contents-form.inc	2016-02-20 11:40:50.000000000 +0100
@@ -8,8 +8,6 @@
 <input type="hidden" name="searchon" value="contents" />
 <label for="keyword"><gettext domain="distrib">Keyword</gettext>:</label>
 <input type="text" size="30" name="keywords" id="keyword" /> &nbsp;
-<input type="submit" value="<gettext domain="distrib">Search</gettext>" />
-&nbsp;<input type="reset" value="<gettext domain="distrib">Reset</gettext>" />
 <br />
 <gettext domain="distrib">Display</gettext>:
 <br />
@@ -30,6 +28,7 @@
   <option value="stable" selected="selected"><gettext domain="distrib">stable</gettext></option>
   <option value="oldstable"><gettext domain="distrib">oldstable</gettext></option>
 </select>
+<br />
 <label for="architecture"><gettext domain="distrib">Architecture</gettext>:</label>
 
 #include "$(ENGLISHDIR)/releases/sid/archive.data"
@@ -43,5 +42,10 @@
  }
 :>
 </select>
+<br />
+<span style="margin-left: 5em;">
+  <input type="submit" value="<gettext domain="distrib">Search</gettext>" />
+  &nbsp;<input type="reset" value="<gettext domain="distrib">Reset</gettext>" />
+</span>
 </p>
 </form>

--- search_packages-form.inc.orig	2016-02-20 03:24:14.000000000 +0100
+++ search_packages-form.inc	2016-02-20 11:41:27.000000000 +0100
@@ -7,7 +7,6 @@
 <p>
 <label for="kw"><gettext domain="distrib">Keyword</gettext>:</label>
 <input type="text" size="30" name="keywords" id="kw" />
-<input type="submit" value="<gettext domain="distrib">Search</gettext>" /> <input type="reset" value="<gettext domain="distrib">Reset</gettext>" />
 <br />
 <gettext domain="distrib">Search on</gettext>:
 <input type="radio" name="searchon" value="names" id="onlynames" checked="checked" />
@@ -29,6 +28,7 @@
   <option value="oldstable"><gettext domain="distrib">oldstable</gettext></option>
   <option value="all"><gettext domain="distrib">any</gettext></option>
 </select>
+<br />
 <label for="releasesection"><gettext domain="distrib">Section</gettext>:</label>
 <select name="section" id="releasesection">
   <option value="main"><gettext domain="distrib">main</gettext></option>
@@ -36,5 +36,10 @@
   <option value="non-free"><gettext domain="distrib">non-free</gettext></option>
   <option value="all" selected="selected"><gettext domain="distrib">any</gettext></option>
 </select>
+<br />
+<span style="margin-left: 5em;">
+  <input type="submit" value="<gettext domain="distrib">Search</gettext>" />
+  <input type="reset" value="<gettext domain="distrib">Reset</gettext>" />
+</span>
 </p>
 </form>

Attachment: signature.asc
Description: OpenPGP digital signature