[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#734507: wml: forgets to remove temporary /tmp/ipp.* directories



Package: wml
Version: 2.0.12ds1-3.1
Severity: important
Tags: patch

Hi,

a temp directory (/tmp/ipp.*) is created to hold a few temp files, which
are then deleted, but the container never is. This results in some
inode-eating contest, at least on the host building the Debian website.
So remove this directory on successful exit (maybe error cases would be
nice to investigate, though…).

Patch attached; also, die, 3.0 (quilt), die, but that's another story.

Mraw,
KiBi.
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,12 @@
+wml (2.0.12ds1-3.1) UNRELEASED; urgency=low
+
+  * Make sure to remove /tmp/ipp.* directories that are created using
+    mkdtemp() to store temporary files, otherwise they would end up
+    eating all inodes (nom nom), which is especially a pain when building
+    the whole Debian website (#debian-www report by taffit).
+
+ -- Cyril Brulebois <kibi@debian.org>  Tue, 07 Jan 2014 19:24:34 +0100
+
 wml (2.0.12ds1-3) unstable; urgency=low
 
   * Fix FTBFS in testsuite on i386 and s390x buildds by not running those
--- a/wml_backend/p1_ipp/ipp.src
+++ b/wml_backend/p1_ipp/ipp.src
@@ -682,6 +682,7 @@ else {
 }
 
 #   die gracefully
+rmdir($tmpdir);
 exit(0);
 
 ##EOF##

Reply to: