[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Quote usage in gettexted WML



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi,

Le 16/08/2011 11:35, Jeroen Schot a écrit :
> Hello Debian-WWW,
> 
> The files english/template/debian/{stat_tags,legal}.wml contain
> constructs like:
> 
>     <: printf '<gettext domain="stats">...</gettext>', %0 :>
> 
> Note the single quotation marks (').

IIRC, the problem is the existing the double quote of "stats"

[…]
> I think the right solutions is to simply replace
> the single quotation marks with double quotation marks.

> I have attached a patch that does this. I can commit it myself if
> there are no objections to it, but would be more confident if a
> regular committer would do this.

Does your patch works ? I mean extracting the PO string *and* building
the resulting page (I would be surprised, in an happy way: I can
remember some headaches over there).

> Index: english/template/debian/legal.wml
> ===================================================================
> RCS file: /cvs/webwml/webwml/english/template/debian/legal.wml,v
> retrieving revision 1.13
> diff -u -r1.13 legal.wml
> --- english/template/debian/legal.wml	16 Aug 2008 12:25:43 -0000	1.13
> +++ english/template/debian/legal.wml	16 Aug 2011 15:32:04 -0000
> @@ -46,10 +46,10 @@
>  <h1>\
>  <ifeq "<license-version/>" ""
>  # title string without version, on the form "dls-xxx - license name: status"
> -"<: printf( '<gettext domain="legal">%s  &ndash; %s: %s</gettext>',
> +"<: printf( "<gettext domain="legal">%s  &ndash; %s: %s</gettext>",

Doesn't printf consider the “<gettext domain=” string only, and the
build brake because of the extra arguments or something like that ?
Escaping the extra double quote would brake the gettext string
extraction IIRC: “<gettext domain=\"legal\">[…]” won't be recognize, or
worse.

Anyway, a proper solution would be welcome here (if you've double
checked your patch, I'll test it too ;-).

Regards

David

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJOXW5hAAoJELgqIXr9/gnyvpcP/iZGmlxx/TQ0BTccxSj8ZxCb
SyDOqwv1TNVsCfk6JTojOzDb5lq/zeTJzg1I53qrwDp81PuFK3cKLZ4P/qcCrZmF
K+b5qotR4uHPeo6pe6i1wrsJN/ceztRkgYfLjsSi1c0Hk9FeNowBdTKik+AZrD/y
YeROfghUul8UJ+9jqisILGdBp3KgL3jLiM+Vr0v3K5R4VpARryaY5RfEPAFiAZxt
GQXFMo7pBXoOCo3ctyZnbSN8UfFm19XACyqIVPNa5olPgMT85c7AAEEqDX6g2zUu
rfflvUODcA3E8q8XBXWN27AV2DiClXlWMhpNA1MWCvpw2fXQVLSQhYGRDSgugYx1
xrhREHsElZOdDtCgb64Jw/0zAsoCMIy+UZEolFI5MObP4gZm4e1Hdk7jtm46FHap
R2Ah2RAF6c7G5QF1sX9oSmj+Pw1fSn+1At4G4bZS62fuYk39my49rCWWydH/GVjy
MG0MvdwhoEEcn+uNxBF33LAIy92qznWgweaXMZuxJpqs9NfKHs9T3UUctqw0N/B8
xHy628rvI6nC49G1R4wN5Waaf0dTh7myB2hqh6Kj3XmzJ9Hg9cbiOzza6lhOQRnj
0FYQKOjFYcX5hU/0r91IFFo5sClvotiAVJqlTuc2208BB8LOdjO5qNRFiDJqBAlI
eH0CCe378SeX/w15u7sZ
=JcCz
-----END PGP SIGNATURE-----


Reply to: