Your message dated Tue, 9 Nov 2010 20:44:06 +0100 with message-id <20101109194406.GA32392@edna.deb.at> and subject line Re: Bug#600200: packages.d.o: switch to API providing versioned screenshots has caused the Debian Bug report #600200, regarding packages.d.o: switch to API providing versioned screenshots to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org immediately.) -- 600200: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=600200 Debian Bug Tracking System Contact owner@bugs.debian.org with problems
--- Begin Message ---
- To: bts <submit@bugs.debian.org>
- Subject: packages.d.o: switch to API providing versioned screenshots
- From: Paul Wise <pabs@debian.org>
- Date: Thu, 14 Oct 2010 23:24:44 +0800
- Message-id: <1287069884.28791.11.camel@chianamo>
Package: www.debian.org Severity: wishlist Tags: patch X-Debbugs-CC: Christoph Haas <haas@debian.org> The attached (untested) patch switches packages.d.o to the API that provides versioned screenshots. If the requested version does not exist it goes with the closest lower version. If no lower version exists it goes with the closest higher version. So we avoid showing features that a newer version would have. Please apply. -- bye, pabs http://wiki.debian.org/PaulWiseFrom 00f2ab8d29bcc25f764c48ea0641225bf23beed2 Mon Sep 17 00:00:00 2001 From: Paul Wise <pabs@debian.org> Date: Thu, 14 Oct 2010 23:17:14 +0800 Subject: [PATCH] Use versioned screenshots on binary package pages --- templates/config.tmpl | 2 +- templates/html/show.tmpl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/templates/config.tmpl b/templates/config.tmpl index aa1dee5..4d24e05 100644 --- a/templates/config.tmpl +++ b/templates/config.tmpl @@ -24,7 +24,7 @@ cn_help_url = project_homepage _ 'intro/cn' patch_tracking_url = 'http://patch-tracker.debian.org/package' screenshots_url = 'http://screenshots.debian.net/package/' - screenshots_thumb_url = 'http://screenshots.debian.net/thumbnail/' + screenshots_thumb_url = 'http://screenshots.debian.net/thumbnail-with-version/' logo = { url => project_homepage, src => '/Pics/openlogo-nd-25.png', diff --git a/templates/html/show.tmpl b/templates/html/show.tmpl index e86af33..ebbba77 100644 --- a/templates/html/show.tmpl +++ b/templates/html/show.tmpl @@ -64,7 +64,7 @@ <div id="pmoreinfo"> <h2>[% g('Links for %s', pkg) %]</h2> [% IF screenshots_url && screenshots_thumb_url && !is_source %] -<a id="screenshot" href="[% screenshots_url _ pkg %]"><img src="[% screenshots_thumb_url _ pkg %]" alt="Screenshot" border="0"/></a> +<a id="screenshot" href="[% screenshots_url _ pkg %]"><img src="[% "$screenshots_thumb_url/$pkg/$version" %]" alt="Screenshot" border="0"/></a> [% END %] <h3>[% g('%s Resources:', organisation) %]</h3> <ul> -- 1.7.1Attachment: signature.asc
Description: This is a digitally signed message part
--- End Message ---
--- Begin Message ---
- To: Paul Wise <pabs@debian.org>, 600200-done@bugs.debian.org
- Subject: Re: Bug#600200: packages.d.o: switch to API providing versioned screenshots
- From: Gerfried Fuchs <rhonda@deb.at>
- Date: Tue, 9 Nov 2010 20:44:06 +0100
- Message-id: <20101109194406.GA32392@edna.deb.at>
- In-reply-to: <1287069884.28791.11.camel@chianamo>
- References: <1287069884.28791.11.camel@chianamo>
Hi! * Paul Wise <pabs@debian.org> [2010-10-14 17:24:44 CEST]: > The attached (untested) patch switches packages.d.o to the API that > provides versioned screenshots. If the requested version does not exist > it goes with the closest lower version. If no lower version exists it > goes with the closest higher version. So we avoid showing features that > a newer version would have. Please apply. There is only one minor "issue" with the patch, it resulted in an URL containing // - we might clean that up later but I didn't feel like changing your commit right now, it works with that. Applied. Rhonda
--- End Message ---