Re: [RFC] website translation stats: split untranslated pages

[Luca Monducci <luca.mo@tiscali.it>]

Hi Frans,

Sorry for delay ;-)

> On Sunday 21 January 2007 03:24, Frans Pop wrote:

[cut]

> Any comments on this? If not, I'll commit tomorrow.

The generated pages aren't HTML valid. Please apply this patch to fix
the issue.  Moreover the patch force a common footer for index page and
per-language pages. 

Cheers,
Luca

PS I'm not subscribed to debian-www, so please cc me



--- stattrans.pl.old    2007-03-26 20:08:49.375000000 +0200
+++ stattrans.pl        2007-03-31 16:48:19.296875000 +0200
@@ -420,7 +420,7 @@
                 print HTML "<li><a href=\"#outdated\">Outdated translations</a></li>\n";
             }
             if (($u_body) || ($ui_body) || ($un_body) || ($uu_body)) {
-                print HTML "<li>Untranslated</li>\n";
+                print HTML "<li>Untranslated\n";
                 print HTML "<ul>\n";
                 if ($u_body) {
                     print HTML "<li><a href=\"#untranslated\">General pages</a></li>\n";
@@ -434,7 +434,7 @@
                if ($uu_body) {
                    print HTML "<li><a href=\"#untranslated-user\">Consultant/user pages</a></li>\n";
                 }
-                print HTML "</ul>\n";
+                print HTML "</ul></li>\n";
             }
             if ($t_body) {
                 print HTML "<li><a href=\"#uptodate\">Translated pages (up-to-date)</a></li>\n";
@@ -518,11 +518,11 @@
                 printf HTML "<td style=\"background-color: %s\" align=right>%d (%d%%)</td>", $color_u, $po_untranslated{'total'}{$lang}, $percent_po_u{'total'}{$lang};
                 printf HTML "<td align=right>%d</td>", $po_total{'total'};
                 print HTML "</tr>\n";
-               print HTML "</table>\n";
+                print HTML "</table>\n";
             }
 
             # outputs footer
-            print HTML "<hr><address>Compiled at $date</address>\n";
+            print HTML "<hr><address>Created with <a href=\"http://cvs.debian.org/webwml/stattrans.pl?cvsroot=webwml\";>webwml-stattrans</a> at $date</address>\n";
             print HTML "</body></html>";
             close (HTML);
         }
@@ -674,8 +674,7 @@
 print HTMLI "</table>\n";
 # print HTMLI $border_foot;
 
-print HTMLI "<p><hr>\n";
-print HTMLI "<p>Created with <a href=\"http://cvs.debian.org/webwml/stattrans.pl?cvsroot=webwml\";>webwml-stattrans</a> at $date\n";
+print HTMLI "<hr><address>Created with <a href=\"http://cvs.debian.org/webwml/stattrans.pl?cvsroot=webwml\";>webwml-stattrans</a> at $date</address>\n";
 print HTMLI "</body></html>\n";
 close (HTMLI);