Re: navbar.wml, basic.wml changes for nm.debian.org
On Fri, Dec 15, 2006 at 07:56:02PM +0100, Christoph Berg wrote:
> Hi,
>
> https://nm.debian.org uses the webwml templates. The problem is that
> we are currently loading the Debian logos from www.debian.org, which
> triggers a security warning in browsers. I can easily redefine PICS to
> point to nm.d.o, but that fails for openlogo-nd-50.png and the css
> files because I still want HOME to point to www, just not for those
> external resources. I'd like to add 2 variables, CSS_HOME and
> PICS_HOME so I can use copies of those files.
The patch seems technically fine. I find the names of the variables
wrong though. HOME has really nothing to with these locations, but
it is indeed a good default. Plus we already have PICS, so PICS_HOME
as a seperate variable is slightly confusing. I propose to change the
names to CSS and LOGOS.
Gruesse,
--
Frank Lichtenheld <djpig@debian.org>
www: http://www.djpig.de/
Reply to: