[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Remaining tidy issues



Hi,

after fixing usge of illegal • characters,
http://people.debian.org/~alfie/tidy/en still contains a few issues:

*** /org/www.debian.org/www/News/weekly/1999/14/index.en.html
line 76 column 1 - Warning: <a> Anchor "logo" already defined

This occurs 9 times and is fixed by

Index: english/template/debian/navbar.wml
===================================================================
RCS file: /cvs/webwml/webwml/english/template/debian/navbar.wml,v
retrieving revision 1.71
diff -u -r1.71 navbar.wml
--- english/template/debian/navbar.wml	9 Mar 2005 05:01:57 -0000	1.71
+++ english/template/debian/navbar.wml	6 May 2005 13:59:36 -0000
@@ -3,10 +3,10 @@
 
 <div id="header">
    <div id="upperheader">
-   <div id="logo">
+   <div id="upperheaderlogo">
   <a href="$(HOME)/"><img src="$(HOME)/logos/openlogo-nd-50.png" alt="" /></a>
   <a href="$(HOME)/" rel="start"><img src="$(PICS)/debian.png" alt="<debianproject/>" /></a>
-  </div> <!-- end logo -->
+  </div> <!-- end upperheaderlogo -->
 <div id="serverselect">
 <when <not "$(NOMIRRORS)"/>>
   <mirrors-serverlist/>
Index: english/debian.css
===================================================================
RCS file: /cvs/webwml/webwml/english/debian.css,v
retrieving revision 1.22
diff -u -r1.22 debian.css
--- english/debian.css	28 Apr 2005 20:45:21 -0000	1.22
+++ english/debian.css	6 May 2005 13:59:36 -0000
@@ -6,8 +6,8 @@
 normal page:
 <div id="header">
   <div id="upperheader">
-     <div id="logo">
-     </div> <!-- end logo -->
+     <div id="upperheaderlogo">
+     </div> <!-- end upperheaderlogo -->
      <div id="serverselect">
      </div> <!-- end serverselect -->
   </div> <!-- end upperheader -->
@@ -68,7 +68,7 @@
    background: white;
 }
 
-#logo {
+#upperheaderlogo {
    float: left;
    margin-left: 6px;
    background: white;

I do not know whether it is OK for tidy to complain, since the logo
anchor in the page mentioned above works great. I know from toddy
that tidy has sometimes wrong reports such as
*** /org/www.debian.org/www/devel/buildd/operation.en.html
line 84 column 1 - Warning: <caption> attribute "align" has invalid value "bottom"
which is fixed upstream IIRC.

Since the patch above requires a complete rebuild I haven't yet
committed. Maybe it's also a good idea to use a special namespace for
id's defined in templates such as 'debian': id="debian.logo"
(I'm not sure whether the dot is valid) or to use classes 
<div class="logo"> and in .css
.logo { ... }?

Jens



Reply to: