Two issues regarding english/international/l10n/*
Hi there!
I now stumbled upon some things while I tried to update the files below
this directory for the german translation:
english/international/l10n/templates -- contains the following name:
stattrans.pl:63: skipdir => [ "template" ],
stattrans.pl:74: skipdir => [ "template" ],
... it looks like that skipdir is also taken for substrings so the .wml
files in this directory aren't considered when generating the
translation statistics which is a bit annoying (and false ;)
The following patch seems to fix the problem:
------------------------------------------------------------------------------
--- Cvsinfo.pm.old Mon Sep 24 07:49:59 2001
+++ Cvsinfo.pm Sat Feb 16 12:01:59 2002
@@ -211,7 +211,7 @@
my $sub = "\$_ = shift; if (-d \$_) { return 1 if m{^(.*/)?CVS\$};";
ref($self->{OPTIONS}->{skipdir}) eq "ARRAY" and do {
foreach (@{$self->{OPTIONS}->{skipdir}}) {
- $sub .= "return 1 if m{$_};";
+ $sub .= "return 1 if m{/$_\$};";
}
};
$sub .= "return 0; }";
------------------------------------------------------------------------------
I guess that's quite straight forward and should be obviously right -
but still I like to you to see it directly (it worked at least in my
local german/english only repository). I have already commited it.
The other issue is: Why is english/international/l10n/{po,templates}/menu.inc
the same file with the same content? Can't this please be combinded or
is that because of some future branches that might happen? I don't
think that it makes much sense - can't that be copied one directory
higher and be just one file?
alfie@asgard:~/work/Debian/CVS/webwml$ diff english/international/l10n/{po,templates}/menu.inc
alfie@asgard:~/work/Debian/CVS/webwml$
Just a thought,
Alfie
--
Perl modules tend to have nicely hierierachical layout and good
descriptive names (except for when they don't).
-- Joey Hess in <20011008165337.A15052@kitenet.net>
Reply to: