[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#994644: Bug#1075586: trickle: ftbfs with GCC-14



Control: tag 1075586 patch
Control: forwarded 1075586 https://github.com/mariusae/trickle/issues/34#issuecomment-2134139388

On Wed, Jul 03, 2024 at 12:46:27PM +0000, Matthias Klose wrote:
> [...]
> xdr.c: In function ‘xdr_msg’:
> xdr.c:106:32: error: passing argument 5 of ‘xdr_union’ from incompatible pointer type [-Wincompatible-pointer-types]
>   106 |               xdr_msg_discrim, _xdr_void));
>       |                                ^~~~~~~~~
>       |                                |
>       |                                bool_t (*)(void) {aka int (*)(void)}
> [...]
> make[2]: *** [Makefile:529: xdr.o] Error 1
> make[2]: Leaving directory '/<<PKGBUILDDIR>>'
> make[1]: *** [Makefile:407: all] Error 2
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
> dh_auto_build: error: make -j1 returned exit code 2
> make: *** [debian/rules:6: binary] Error 25
> dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

With the patch

| --- a/xdr.c
| +++ b/xdr.c
| @@ -103,7 +103,7 @@ xdr_msg(XDR *xdrs, struct msg *msg)
|  {
|  	X(xdr_short(xdrs, &msg->status));
|  	X(xdr_union(xdrs, (int *)&msg->type, (char *)&msg->data,
| -	      xdr_msg_discrim, _xdr_void));
| +	      xdr_msg_discrim, (xdrproc_t)_xdr_void));
| 
|  	return (TRUE);
|  }

as mentioned in
<https://github.com/mariusae/trickle/issues/34#issuecomment-2134139388>
trickle builds again.

Gürkan Myczko, do you still intend to adopt trickle as stated in
<https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=994644>? If so, the
above might help. Otherwise please state there accordingly, easing the
path for a QA upload not stepping on your toes in any way. After all,
trickle has already been removed from testing due to this bug, cf.
<https://tracker.debian.org/news/1553818/trickle-removed-from-testing/>.

Cheers,
Flo

Attachment: signature.asc
Description: PGP signature


Reply to: