[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1051940: RFS: golang-github-stefanhaller-tcell/0.0~git20230806.2dfa11e-1 [ITP]



On Thu, Sep 14, 2023 at 08:46:07PM +0530, Jongmin Kim wrote:
> I am looking for a sponsor for the package "golang-github-stefanhaller-tcell".
> This package is a prerequisite for the package "lazygit" (#908894)[1,2].
> 
>   [1] https://bugs.debian.org/908894
>   [2] https://github.com/jesseduffield/lazygit-debian/wiki/Dependency-graph
> 
> The package upstream[3] is a forked version of tcell[4] which is already
> packaged in Debian archive[5]. However, the package is needed due to
> forked upstream modified some functions[6] for lazygit, which have
> discrepency from the original.

I think this is not needed at all. The only delta it has with gdamore/tcell is this
commit[7] which has been merged into upstream (gdamore/tcell) now, see[8].

And digging into lazygit's commits, you'd see that the change of fork in go.mod[9] has the
commit message:

"""
This is temporary as long as gdamore/tcell#599 is not
merged. Once that PR is merged, we can revert this.
"""

IMHO, the next steps would be:
* Ask gdamore/tcell to tag a new release so the debian package could be updated
  easily
* Ask lazygit's upstream to adapt back to gdamore/tcell


>   [3] https://github.com/stefanhaller/tcell
>   [4] https://github.com/gdamore/tcell
>   [5] https://tracker.debian.org/pkg/golang-github-gdamore-tcell.v2
>   [6] https://github.com/stefanhaller/tcell/commits/main
[7]: https://github.com/stefanhaller/tcell/commit/b7e509067a02e8e0d43bc800293668c4d67f5b19
[8]: https://github.com/gdamore/tcell/pull/599
[9]: https://github.com/jesseduffield/lazygit/commit/4aca854b5924b3228f9e69f7bc85dbb1287b4a3e

Best,
Nilesh

Attachment: signature.asc
Description: PGP signature


Reply to: