Bug#1037306: ITP: apycula -- Tools to generate Gowin FPGA bitstreams
Hi Simon,
On Sat, Jun 24, 2023 at 10:00:39PM +0900, Simon Richter wrote:
> I'm looking at trellis first:
>
> - the bit_to_svf.py script is not installed
It's not installed by the `make install` target. If upstream wants it
installed, they probably shoud do so :)
I can install it into docs if you like but the generic name prevents
installation into /usr/bin IMO.
> - Rachel suggests https://prjtrellis.readthedocs.io/en/latest/ as the
> homepage link, any opinion on whether that is a better choice than the
> github page?
I prefer upstream source repos as Homepage TBH. The docs are linked to from
the README so I think they should be easy enough to discover.
Debian policy has this to say on the matter:
| 5.6.23. Homepage
|
| The URL of the web site for this package, preferably (when applicable)
| __the site from which the original source can be obtained__ and any
| additional upstream documentation or information may be found.
So I think my intuition is correct here.
> - dh_auto_configure and dh_auto_install are overridden with the default
> behaviour.
Yeah I forgot to do a final cleanup pass after getting nextpnr working :)
Will rectify with the next upload.
I also got a review from Jonathan Neuschäfer saying that trellis chipdbs
are installed into the wrong path and nextpnr barfs so we'll have to upload
a fixed version anyway.
Do you know if we have to wait to clear the NEW queue or can we just upload
another revision right away?
> - the "Unlicense" is, very strictly speaking, a crayon license, although
> the intention is clear. The FTP team might object here, or just shrug, so
> not a blocker to uploading IMO.
Indeed in some countries giving up copyright as such is simply not
possible. My home country (Austria) doesn't allow this either for
example. Aber "wo kein kläger da kein richter" ;)
> Other than that, the package is very good, and ready for upload.
>
> Will look at apycula now.
I see you already uploaded it now. Great!
Did you make any changes either of the the packages? If so don't forget to
commit and push to salsa please. You should have push access to
electronics-team, right?
Also I see the debian/* tags are still missing please don't forget to push
them.
If you forgot to run gbp-buildpackage with --git-tag it's best to use `gbp
import-dsc` to import the source package you just uploaded and push
that. IIRC this will create the debian/* tag too.
You can push everything using `gbp push origin` and if that doesn't work
(it fails sometimes for me):
git push --tags && git push origin master upstream
Thanks,
--Daniel
Reply to: