[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1034495: ITP: linux-board-support-package-dragonboard845c -- Firmware for dragonboard845c / RB3



On Mon, 17 Apr 2023 at 03:09, Roger Shimizu <rosh@debian.org> wrote:
>
> Package: wnpp
> Severity: wishlist
> Owner: Roger Shimizu <rosh@debian.org>
> X-Debbugs-Cc: debian-devel@lists.debian.org
>
> * Package name    : linux-board-support-package-dragonboard845c
>   Version         : 20190529180356-v4
>   Upstream Author : Linaro
> * URL             : https://releases.linaro.org/96boards/dragonboard845c/qualcomm/firmware
> * License         : non-free
>   Description     : Firmware for dragonboard845c / RB3
>
>  This package contains the binary firmware for GPU, USB, DSP hardware
>  coprocessors found on SDM845, which is the main SoC on the
>  Dragonboard 845c / RB3.

Generally, I think there is some misunderstanding here. Most of the
firmware has been pushed to linux-firmware already (where possible).
You probably have some other intentions here. If so, please describe them.

I took a glance at the package sources on salsa. So, let's go at this
one by one.

firmware-qcom-dragonboard845c.install:

[0-9]*/prog_firehose_ddr.elf lib/firmware/qcom/sdm845

This is the file that is only used by the _host_ when programming the
device. As such, it should not be a part of the en-device firmware. It
has no use for the RB3 itself.

[0-9]*/aop.mbn lib/firmware/qcom/sdm845

Bootloader. It should not be a part of /lib/firmware/

[0-9]*/BTFM.bin lib/firmware/qcom/sdm845

This is the filesystem image with bluetooth firmware files. Relevant
files are already part of the /lib/firmware/qca. If anything important
is missing there, it should directly into

[0-9]*/cmnlib.mbn lib/firmware/qcom/sdm845
[0-9]*/cmnlib64.mbn lib/firmware/qcom/sdm845
[0-9]*/devcfg.mbn lib/firmware/qcom/sdm845

These three files are also used by the bootloader process, and as such
they should not be a part of /lib/firmware.

[0-9]*/dspso.bin lib/firmware/qcom/sdm845

This is probably the only important file for now. This is the
filesystem image with the shared libraries and executable code for the
DSPs when executing compute applications there.
We were putting it to /lib/firmware/qcom/sdm845 and mounting it later,
because it was easier to do so (if the image is not present in
/lib/firmware, the rootfs can try mounting dspso parition). For proper
Debian packaging the image should be unpacked to some agreed location.
fastrpc daemons then should be taught about this location.

[0-9]*/hyp.mbn lib/firmware/qcom/sdm845
[0-9]*/imagefv.elf lib/firmware/qcom/sdm845
[0-9]*/keymaster64.mbn lib/firmware/qcom/sdm845
[0-9]*/sec.dat lib/firmware/qcom/sdm845
[0-9]*/storsec.mbn lib/firmware/qcom/sdm845
[0-9]*/tz.mbn lib/firmware/qcom/sdm845
[0-9]*/xbl.elf lib/firmware/qcom/sdm845
[0-9]*/xbl_config.elf lib/firmware/qcom/sdm845
[0-9]*/qupv3fw.elf lib/firmware/qcom/sdm845

Again, mostly bootloader stuff. I highly doubt that /lib/firmware
should be polluted with these files.

renesas_usb_fw.mem lib/firmware

So, this is the Renesas firmware, which gets copyrighted by Qualcomm.
We noticed this some time ago (and the fact that the supplier of the
firmware, Thundercomm, also pulled the file without having a clear
origin). We have been trying to clear licensing terms for this file,
however Renesas is unresponsive. Originally this file came from the
author (Renesas) without proper license. Thus I do not believe it
passes required checks by ftpmasters.

linaro-abl/aosp/* lib/firmware/qcom/sdm845/abl-aosp
linaro-abl/linux/* lib/firmware/qcom/sdm845/abl-linux

I don't know what this is, but judging from the name (ABL) it also
should not be part of /lib/firmware. Especially the AOSP file.

Next package:
network-manager-config-dragonboard845c.install

debian/eth-mac-addr.conf usr/lib/NetworkManager/conf.d/

I do not think this should be a part of the
firmware-qcom-dragonboard845c source package. It is not a firmware.

> If you have any concerns, or you can offer co-maintenance of the package in Debian, please let me know.

Well, I'd like to understand your intentions with this package. Please
feel free to ask any questions regarding these files or about
packaging them.

-- 
With best wishes
Dmitry


Reply to: