[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1023160: ITP: libghc-filesystem -- Implementation of C++17 std::filesystem for C++11-20



Control: tags -1 wontfix

Am 15.01.23 um 04:44 schrieb Ben Westover:
Hello,

On 1/8/23 10:59 AM, Bastian Germann wrote:
Looking at Prism Launcher's source, this library is really unnecessary.
Compiling with g++ -std set to c++17 or c++20 should do the trick.
Maybe you have to patch the build system not to look for the library.

What in the source makes you think the library is unnecessary? I'm not experienced with C++, but it seems that launcher/FileSystem.cpp makes use of ghc::filesystem and some of its specific quirks.

I have already pointed out the conditional use of it.
Just search for the appearance of that and you will find the single file that actually uses the filesystem and preferably uses the std:: implementation over the libghc. So no, it does not rely on any "specific quirks".

I am tagging wontfix as I have just built your prismlauncher RFS package without ghc filesystem and verified my suspicion.


Reply to: