On Thu, 10 Aug 2023 19:16:55 +0545 Nisha Pariyar <nishapariyar48@gmail.com> wrote: > * Package name : golang-github-dsnet-compress > Version : 0.0.1-1 > Upstream Author : Joe Tsai > * URL : https://github.com/dsnet/compress > * License : BSD-3-clause > Programming Lang: Go > Description : Collection of compression related Go packages. > > Collection of compression libraries for Go > . > A collection of pure Go libraries for popular compression algorithms, > designed to extend the Go standard library capabilities. Includes > implementations of Brotli (RFC 7932), BZip2, DEFLATE (RFC 1951), and > XFLATE formats. Offers a balance between maintainable code, > performance, and flexibility. Active development; API stability not > guaranteed. Requires Go 1.9+. I wanted to ask a couple of questions before I start with a review: * Is there a package that needs dsnet/compress? If so, which one - and is it a crucial dependency? * The README says that: NOTE: This library is in active development. As such, there are no guarantees about the stability of the API. The author reserves the right to arbitrarily break the API for any reason. This does not sound very good in debian's context. Breaking APIs in major releases are still OK, but I'm a little concerned about this in for instance patch/minor releases. * There's a compression library https://github.com/klauspost/compress which is already in debian (golang-github-klauspost-compress). The additional functionality that dsnet/compress seems to provide is brotli compression/decompression. If this is not used eventually (assuming this package is dep of another package that you're trying to get in) do you think it'd be possible to patch the code and convince upstream? In principle I'd have just started with a review and uploaded eventually but the API problem made me re-think. Let me know. Best, Nilesh
Attachment:
signature.asc
Description: PGP signature