[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1016558: O: muse-el



Nicholas D Steeves <sten@debian.org> writes:

> Hello,
>
> Sorry for the delay, I hadn't realised that I had forgotten to actually
> send this draft:
>
> On Fri, 11 Aug 2023 at 22:09, Manphiz <manphiz@gmail.com> wrote:
>
>> Nicholas D Steeves <nsteeves@gmail.com> writes:
>
>> Now also uploaded my PGP keys to https://keys.openpgp.org/.  pgp.mit.edu
>> has been unstable for a while, so a good alternative is definitely a
>> plus :)
>
> For sure, and also, it's been the default keyserver in Debian since 2019
> (gnupg 2.2.17-1) ;) Yeah, I've also noticed pgp.mit.edu has gotten
> slower and more unreliable than in the past.  P.S. This might be a bit
> pedantic, but doesn't your key have five redundant signatures that could
> be deleted?
>

Should have removed the redundant signatures and reuploaded to
https://keys.openpgp.org, though I don't think I had 5 signatures on the
same IDs? Anyway, PTAL.

>> >> I: muse-el source: patch-not-forwarded-upstream
>> >> [debian/patches/0005-convert-a-muse-init.el-example-to-UTF-8.patch]
>> >>
>> >> I wonder whether you would also like to forward this patch upstream.
>> >
>> > If you really want to, go ahead, but I'm not interested in the FSF's
>> > identity verification for copyright assignment process, so this might
>> > end up as a futile effort.  In light of this, a "hey, we have a UTF8
>> > conversion patch...would you like to convert your copy to UTF8 either
>> > with or without our patch" might be smoother.  If you happen to have
>> > have done FSF copyright assignment paperwork, please go ahead and
>> > claim ownership of that trivial patch.
>>
>> Forwarded upstream.  As my pull request got merged fairly quickly I'm
>> slightly more optimistic here.
>
> Hmm, it appears that these patches were forwarded to a fork.  The Source
> is set to git://repo.or.cz/muse-el.git (debian/and the Homepage is set
> to https://www.gnu.org/software/emacs-muse/index.html (debian/control).
> As the new maintainer it's your right to switch upstream sources, but I
> recommend you ask some team members and #debian-mentors on irc or the
> mailing list about what the downsides to this may be; the mailing list
> archives might have a record of someone else asking a question like
> this.  I'll support your decision once you let me know you've
> investigated and considered.

So I did ask around #debian-emacs and #debian-mentors and the replies I
got was to better figure out the situation with the upstream.  So I
opened an issue on the github repo[1] and waiting for response.

>
> What is your intention here?  Are you rebasing our package onto this
> fork, or are you using the fork as a code dump, or something else?
>

Well to be honest I didn't realize the github one was a fork as the
d/watch file had been pointing there.

Also from your other mail:

> I found that this UTF8 issue was already fixed upstream:
> 
>   @@ -412,11 +433,11 @@
>   https://git.savannah.gnu.org/cgit/emacs/elpa.git/commit/?h=externals/muse&id=be347db7f1ad56f0384f76011bfd148ff3352610
> 
> and note that it's now an official GNU project (via copyright assignment)
> 
>   Copyright (C) 2004-2020 Free Software Foundation, Inc.

So it should be clear that the Savannah one should be considered the
canonical upstream.  I'll update my question on github to ask for
whether Alex want to forward the patches in his repo to Savannah as
well.

Also as a result, I've marked the patch as "Forwarded: not-needed".

>> > I'm happy to sponsor from git when you finalise the changelog, but if
>> > ever you want to get some hands-on experience with dput (or dput-ng),
>> > then practise uploading to https://mentors.debian.net/.
>>
>> Uploaded using dput.  Would be great to have you to take a look as
>> well.  Thanks!
>
> The aspects relating to the upload look good to me.
>
> Oh, there's one more thing that needs to be fixed before we upload:
> Bug #1048114

Attempted to fix it in [2] where I just regenerated the changing file in
sbuild.

I have also rebuilt and reuploaded the source.changes to mentors[3].  PTAL.

Thanks!

>
> Take care,
> Nicholas

-- 
Manphiz

[1] https://github.com/alexott/muse/issues/16
[2] https://salsa.debian.org/emacsen-team/muse-el/-/commit/f5c217162d9c6f45c971cec2b8c70b2794bb77fe
[3] https://mentors.debian.net/package/muse-el/

Attachment: signature.asc
Description: PGP signature


Reply to: