On 2022-09-22 17:03:24, Bo YU wrote:
> Hi,
> On Tue, Sep 20, 2022 at 10:56:05AM -0400, Antoine Beaupré wrote:
>>> https://github.com/git-multimail/git-multimail/issues/221#issuecomment-1245009306
>>> (To avoid bring noisy for upstream, i just recorded it in a issue)
>>
>>I don't think pull requests are noisy... you should probably just submit
>>this as a PR upstream.
>
> Ok, got it. Will do.
> Sometime I mentioned the patch in the issue, the maintainer of upstream will
> pick it into if he think that is valuable.
Yeah, that's a reasonable assumption, but I find that maintainers often
process merge requests way more quickly and easily as they just need one
click to merge. :)
[...]
> I think the people found the issue also:
> https://github.com/git-multimail/git-multimail/issues/221#issuecomment-1252529169
>
> Certainly, lintian will give a kindly warning:
> W: git-multimail: script-with-language-extension [usr/bin/git_multimail.py]
>
> If I understand correctly, this is a bug as you said.
> The workround is still to use launcher file in d/ as in previous commit?
I think the simplest solution is not to rewrite the launcher, but to
rename it. So in debian/rules, you would simply do:
override_dh_auto_install:
dh_auto_install
mv debian/git-multimail/usr/bin/git_multimail.py debian/git-multimail/usr/bin/git-multimail
Also, get rid of the noop sections like:
override_dh_installdocs:
dh_installdocs
Cheers!
--
I prefer the tumult of liberty to the quiet of servitude.
- Thomas Jefferson