Bug#996965: CSS help needed for r-cran-bslib (Was: shiny-server in debian)
Hi again,
I've made some progress with bslib but now I have trouble with its
autopkgtest. Bslib provides different versions of bootstrap (version 3,
4 and 5) to provide a unique interface for all R packages. I managed
that the provided unittests are working for bootstrap4 but it fails for
some tests of bootstrap3. This is true for the original bootstrap3
as distributed by Debian as well as the patched version (bslib contains
a set of patches which I applied in the process of packaging). The
erroneous code is not affected by the patch. Here is an example for
the failure:
── Error (test-theme-base-colors.R:45:3): bs3 base colors ──────────────────────
Error in `compile_data(sass_input, options)`: Error: Invalid CSS after "... floor(math": expected expression (e.g. 1px, bold), was ".div($grid-gutter-w"
on line 369:46 of ../../../../../../usr/share/nodejs/bootstrap-sass/assets/stylesheets/bootstrap/_variables.scss
from line 110:1 of stdin
>> vbar-padding-horizontal: floor(math.div($grid-gutter-width, 2)) !defa
------------------------------------------^
Backtrace:
▆
1. └─bslib::bs_get_variables(theme, varnames) at test-theme-base-colors.R:45:2
2. └─sass::sass_partial(...)
3. └─sass::sass(...)
4. └─sass:::compile_data(sass_input, options)
── Error (test-theme-base-colors.R:106:3): bs3 accent colors ───────────────────
This is from the patched code - the full autopkgtest log is here:
https://salsa.debian.org/r-pkg-team/r-cran-bslib/-/jobs/2706701#L1056
If the bslib patches are not applied the autopkgtest log looks like
https://salsa.debian.org/r-pkg-team/r-cran-bslib/-/jobs/2700112#L1056
Any hint how to fix the css code would be really helpful.
Kind regards
Andreas.
Am Thu, Apr 14, 2022 at 04:50:38PM +0200 schrieb Andreas Tille:
> Hi,
>
> Am Thu, Apr 14, 2022 at 11:26:58AM +0200 schrieb Andreas Tille:
> > I did a next step in
> >
> > https://salsa.debian.org/r-pkg-team/r-cran-bslib/-/commit/7d066e14383753156d851e81b0db9e21665ce861
> >
> > where I simply try the patience of ftpmaster to accept binary fonts.
> > I'll now try to sort out the licenses of the different bootstrap
> > versions and hope to upload soon to new.
>
> I've managed to exclude bootstrap3 but there are issues with the
> Debian packaged bootstrap4 which I've reported upstream[1]. I'm now
> checking what I can do for boostrap5 (besides removing it completely
> for the moment and hoping that we can go with boostrap[34] as long
> as version 5 is not packaged yet (I do not have a better idea right
> now :-()
>
> So far for the status of bslib
>
> Andreas.
>
> [1] https://github.com/rstudio/bslib/issues/422
>
> --
> http://fam-tille.de
>
>
--
http://fam-tille.de
Reply to: