Bug#986856: RFP: dangerzone -- Take potentially dangerous PDFs, office documents, or images and convert them to a safe PDF
Hi,
On 4/4/22 03:41, Peymaneh wrote:
@Kunal
Would you mind having a look at it? This is my first package including
post{inst,rm}-scripts and I am not sure if the way i did it is very robust.
Yay! Comments unrelated to the postinst:
* I think dangerzone-container.1 might be outdated, it references
`docker` instead of `podman`.
* in d/rules, just remove the `export DH_VERBOSE` line entirely and use
the default.
* Is python3-stdeb needed? I might've missed something.
* You can drop d/source/local-options, everything is commented out.
* Please try to upstream the .desktop patch
For context:
For the new version upstream has decided to include build a whole
Container-Image at build time and include the 700MB image in the .deb
package. The absurd package size set aside, building the image on the
Debian build servers would not be possible because a network connection
is required for pulling the docker image.
My dangerzone.postinst is basically the build-script from upstream[2]
only with some very basic error-handling added to it.
Definitely agreed that shipping the container in the package itself
would be a big mistake and not feasible for multiple reasons.
I think what you have now is probably acceptable for contrib[1], but far
from ideal, both practically and for the goal of getting it into main.
My opinion of ideal behavior would be that the first time Dangerzone is
opened, it notices the lack of the image, and then starts building it or
pulling it from somewhere (with or without a prompt). It would be worth
discussing such a behavior change with upstream first though. An Arch
Linux maintainer has already asked for something similar at
<https://github.com/firstlookmedia/dangerzone/issues/154>.
[1] I'll inquire with others if they know of other examples like this.
-- Kunal
Reply to: