[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1007108: Fwd: ITP: qpwgraph -- User interface for controlling the PipeWire Graph



Hi Chris,

Thanks for your packaging!

I had a look at it and of course it is good, nothing that could
prevent me to upload it. Just to nitpick:

- salsa-ci.yml is not needed anymore as we can directly use the config
file from the salsa team:
> https://salsa.debian.org/salsa-ci-team/pipeline/blob/master/README.md#basic-use

- If you plan to maintain this package under the umbrella of the
Debian Multimedia Team, you need to move the git repo under the team
namespace and update the d/control fields accordingly. Just created a
repo for you:
> salsa.debian.org:multimedia-team/qpwgraph.git

- Is there a specific reason to target the upstream dev website
instead of the gitlab repo in the d/watch file? I guess he can forget
to update it contrary to its gitlab repo.

- The history of your master and upstream branches is uncommon, I
think you cloned the upstream repo and then imported the upstream
tarball with gbp? It would be cleaner to just create these branches
using gbp import-orig.

Best,
Dylan


Reply to: