[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1017500: ITP: plotjuggler -- Fast, intuitive and extensible time series visualization tool



Davide Faconti <davide.faconti@gmail.com> writes:

> If you tell me more, maybe I can help to remove these dependencies
> (from 3rdparty I guess). Since I am embracing conan for dependencies,
> it should not be a big deal.

Hi. I think removing dependencies from the repo is a good thing to do,
but it would save me only a small bit of time. The biggest effort in
packaging is generally dependencies and copyrights.

I'm going to need to go through the dependency list, and make sure all
the dependencies are in Debian. Anything that's not tiny and not alrady
in Debian will need to be packaged. For PlogJuggler I see these
unpackaged dependencies:

- QCodeEditor
- Qt-Advanced-Docking
- color_widgets
- mcap
- sol

For the copyrights, I'd need to make sure that everything in the repo
has a clear copyright. You don't actually have a statement anywhere.
Somewhere (like in the README) you should say "Copyright YEAR
PlotJuggler contributors" or something. Then this copyright statement
and the LICENSE (that you already have) will apply to everything in your
repo, unless there are explicit notes to the contrary.

You're also shipping some stuff that clearly doesn't adhere to that
copyright statement or to your license: you have a bunch of memes in
plotjuggler_app/resources/memes. You have no idea who made these and
under what terms. I will strip those out. If you do that before I get to
it, I wouldn't need to.

I'm not going to get to this for a bit, since all the dependencies need
to be taken care of first, but it'd be great if the copyrights were
cleared up by the time I get to it.

Thanks!


Reply to: