Bug#884575: ITP: syncthingtray -- a tray applet, plasmoid, and Dolphin integration for Syncthing
Hi Nicholas,
On 21/11/2021 22:13, Nicholas D Steeves wrote:
> Yes, I can create the first two at what will probably be round two of
> the reviews, but I recommend waiting for syncthing-tray, because you may
> prefer a "gbp" style repository for it, for ease of unbundling using
> Files-Excluded. Syncthing-tray also shouldn't be uploaded until the
> first two packages clear the NEW queue, so there's no rush.
>
> [...]
>
> It looks to me like Martchus is bundling a subset of his fork of
> upstream Syncthing. This should be excluded from the Debian
> orig.tarball. This can be done with a script and a source-cleaning git
> branch, plus merging the cleaned tag to debian/main rather than merging
> the upstream tag. Alternatively, it can be automated by using gbp's
> support for Files-Excluded.
Currently, the Syncthing sources are neither included in the upstream
tarballs nor in the upstream git repo. They can be pulled into the
source tree by using the git submodule, but this does not happen unless
you do this explicitly.
Nevertheless, to be sure I have added the `submodules = False` to the
`gbp.conf` file. This ensures that the submodules will never be included
in a tarball built by gbp.
If this situation changes, we might need to change the git repository to
the gbp import-orig workflow, but for now we should be able to keep it
as it is.
> 2) Use a build-system config key to explicitly disable this functionality.
Done.
> Cool, and of course, no pressure. The main reason I propose this is
> because it gives you increased autonomy (allows you to upload a set of
> packages without needing a sponsor). When I had to depend on someone
> for every single upload I was frustrated an demotivated by the long
> waits...because unfortunately it seems that windows of free time often
> don't align, you know?
This is a very good point. Having more autonomy in the long run, seems
to be desirable.
>> - in the syncthingtray package the "package-name-doesnt-match-sonames
>> libsyncthingconnector1.1.10 libsyncthingmodel1.1.10
>> libsyncthingwidgets1.1.10". Since these are quite specific libraries
>> that are only used for Syncthing Tray, I do not see a point in
>> making separate binary packages for each of them. Hence, I would
>> suggest to ignore these warnings for now.
>>
>
> At this time I'm not thinking about this issue; Let's return to this
> question after the two dependencies have been uploaded. Policy will
> need to be consulted
>
> https://www.debian.org/doc/debian-policy/ch-sharedlibs.html
>
> Be it resolved that the current state is indeed the correct direction, a
> minimum solution is a lintian override.
Okay.
> Additionally, no Debian package should bundle fonts (or font-icons).
Why? Which part of the policy manual are you referring to? What are your
concerns regarding pre-rendered icons?
Regards,
Hannah
Reply to: