Hello Hannah, This stuff is in addition to the stuff mentioned in my last email on martchus-cpp-utilities. Some of these items also apply to martchus-qtutilities, but because the latter depends on the former, let's polish and upload martchus-cpp-utilities before working on martchus-qtutilities. First off, I just noticed that the dev package is named "libmartchus-c++utilities5-dev" rather than "libmartchus-c++utilities-dev". Are you certain that this is correct, and if so, why? Please read the section below tagged "no-symbols-control-file", and do the check mentioned in that section when thinking about this. Resolving this question is a blocker. To get tips for resolving these directly from lintian (vs using a web browser to search for the tags), use the following command: $ lintian --display-level ">=info" --info I: libmartchus-c++utilities5: hardening-no-bindnow [usr/lib/x86_64-linux-gnu/libmartchus-c++utilities.so.5.11.1] I: libmartchus-c++utilities5: hardening-no-fortify-functions [usr/lib/x86_64-linux-gnu/libmartchus-c++utilities.so.5.11.1] * I think that it is reasonable and easily justifiable to defer resolving these two until after we have a working Syncthing Tray. Thus I will not support overriding them unless making these changes has been shown to cause problems, and these tags provide a useful reminder to investigate later. (p.s. Please configure your lintian to emit Info-level tags by default. Don't worry, I won't insist on resolving the experimental ones that are hidden by default) I: libmartchus-c++utilities5: no-symbols-control-file usr/lib/x86_64-linux-gnu/libmartchus-c++utilities.so.5.11.1 * Policy §8.6 https://www.debian.org/doc/debian-policy/ch-sharedlibs.html#s-sharedlibs-depends * debhelper autogenerates a DEBIAN/shlib in the binary package. Its correctness can be verified after a "dpkg-deb -R file.deb target_dir" * I'd recommend overriding this one, with a comment that provides justification, because this demonstrates awareness of the requirements and awareness of how those requirements have been fulfilled. I: martchus-cpp-utilities source: override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS (line 14) * See lintian tag description for how easy this is to resolve. I: martchus-cpp-utilities source: patch-not-forwarded-upstream debian/patches/0001-namespace.patch * It will make you look good if you fix this one, because IIRC it was forwarded upstream ;-) https://dep-team.pages.debian.net/deps/dep3/ Best, Nicholas
Attachment:
signature.asc
Description: PGP signature