Bug#975985: ITA: geda-gaf -- Electronics design software
Am 01.10.21 um 14:30 schrieb Roland Lutz:
On Fri, 1 Oct 2021, Bastian Germann wrote:
I pushed an edited version of your changes to
https://salsa.debian.org/electronics-team/geda-gaf/-/tree/ita975985
So you rebased the history instead of adding your changes as commits? This makes
it hard to track what exactly you have changed.
I rebased so that all the do/undo commits are gone. I did not apply any changes
except the man page move and the GFDL license rename but rather removed some of
your changes.
There were some changes outside debian/ that were reverted later on. That is bad
for review. It is better to rebase on your side as long as you are developing
and the changes are not in master.
For you to notice the changes, just use git diff.
man page is not a patch but a file in debian/. A .manpages file has still to
be added for the package that holds xorn to include it
Ah, good to know.
(should be in geda-utils, not in libgeda-common).
I don't think geda-utils is the proper package for the xorn command-line tool.
If it shouldn't be in libgeda-common (why not?), geda-cli would be the next more
plausible choice, or a separate package of its own (though it could be argued
that gEDA/gaf is split into enough packages already).
The GFDL situation: Do not just patch the license texts of upstream. While in
this case Roland holds the copyright probably, this is generally not allowed.
The only case where GFDL can be included is in its GFDL-NIV variant excluding
immutable sections (should be the case here). There are 1.2 and 1.3 files. The
license text for 1.3 is missing and so are the files that are 1.2 licensed.
I'm not quite sure what follows from this. Is this an upstream bug?
I did not have a thorough look at the license reference texts, so I do not know.
As you are the author, I guess you can clarify this in upstream.
More info about why GFDL with some of its extensions is not allowed in main
section: https://wiki.debian.org/GFDLHistory
Without any upstream changes: For the package, just duplicate the GFDL-NIV-1.2+
license section to a GFDL-NIV-1.3+. Find out the files that are GFDL-NIV-1.2+
licensed (e.g., NEWS) and add them to d/copyright.
I got rid of some package renames.
You mean the renaming of "geda-gaf" into "geda-cli"? I believe "geda-gaf" is an
unfortunate naming for the package with the "gaf" command-line tool as
"gEDA/gaf" is the name of the entire project, and accordingly, the source
package is also named "gead-gaf". The "gaf" tool is useful, but by no means the
central component of gEDA/gaf.
As long as the package still (build-)depends on Python 2 I will not upload it.
So please get rid of the Python files in the packages and patch the files that
are executed during the build.
That is not feasible. gEDA/gaf contains multiple Python extensions, and while
the bulk of the work of porting them away from CPython 2 has been done, patching
the necessary code and build system changes into the Debian package would be a
nightmare. If the Python 2 dependency blocks uploading gEDA/gaf 1.10.2, the
realistic consequence would be to wait for a release that changes this dependency.
Roland
I was on the impression that somebody included the necessary changes in the py3
patch. But if it is that nightmarish, we should wait.
Reply to: