Bug#951374: RFP: gh -- the GitHub CLI
Hi Brian,
Sorry for the late reply.
On Mon, Aug 16, 2021 at 10:56 PM Brian Thompson <brian@hashvault.io> wrote:
> On Mon, 2021-08-16 at 21:27 -0600, Anthony Fok wrote:
> >
> > Now, you might run into a problem when actually trying to name the
> > package "github-cli" (or even "gh") because dh-make-golang 0.4.0 does
> > not allow for overriding the package name. For example:
> >
> > dh-make-golang -type p -pristine-tar github.com/cli/cli
> >
> > would name the package "cli"... I am working on packaging the latest
> > dh-make-golang and will try to add a flag to allow overriding the
> > package name, to be uploaded as dh-make-golang 0.4.1 or 0.5.0.
>
> It sounds like this functionality is required for what we are trying to achieve.
> I am not very familiar with the golang family and its surrounding infrastructure
> regarding Debian. Perhaps I am not best-equipped to package the github-cli tool,
> but I am always willing to learn.
That's awesome! Welcome to the Debian Go Packaging Team!
You may start by taking a look at https://go-team.pages.debian.net/ .
I am happy to report that dh-make-golang 0.5.0-1 has been uploaded,
which means now you can name the package "gh" (to match the name of
the Debian package provided upstream on GitHub) by using the following
command:
dh-make-golang -pristine-tar -program_package_name gh github.com/cli/cli
(the -pristine-tar option is just my personal preference and is optional.)
> > Then there are the yet-to-be-packaged dependencies. Just so that you
> > know, the following packages that github-cli depends on have already
> > been packaged but currently sitting in the
> > https://ftp-master.debian.org/new.html NEW queue:
> >
> > * golang-github-yuin-goldmark-emoji 1.0.1-1
> > * golang-github-muesli-reflow 0.3.0-1
> > * golang-github-shurcool-graphql 0.0~git20200928.18c5c31-1
> > * golang-github-shurcool-githubv4 0.0~git20210725.83ba7b4-1
Hurray! These 4 packages have entered Debian! (Thanks to FTP Masters!)
> > I'll report back here if I were to package and upload more of these
> > dependencies so as to avoid duplication of work.
> It sounds like we should pause the github-cli technical packaging work until
> dependent features and packages are added to the ecosystem. Would you agree with
> that? I'm not seeing any BTS tags specific to RFPs (or bugs in general) for
> marking it as "blocked", as we would say in the corporate world. Although I am
> not sure that is even necessary.
Well, we won't know what the dependencies are until we start packaging
gh, so we would start by running dh-make-golang which will give us
more information such as the yet-to-be-packaged dependencies.
Yes, it would be a good idea to mark the relevant ITP/RFP bugs as
blocking for gh. Not strictly necessary, but definitely helpful to
have the ITP/RFP bugs connected to this bug, otherwise it is hard to
keep track of them.
So yes, with the new dh-make-golang 0.5.0, you can start packaging gh
and its dependencies any time now! Make sure to double check the NEW
queue and WNPP to ensure you are not doing work that has already been
done by others. :-)
Let's begin!
Cheers,
Anthony
Reply to: