Bug#992133: firebird4.0 debian packaging

[Frank Doepper <fd@taz.de>]

Am 26.08.21 um 10:40 schrieb Damyan Ivanov:
> -=| Damyan Ivanov, 26.08.2021 09:34:04 +0300 |=-
> > -=| Frank Doepper, 25.08.2021 16:58:15 +0200 |=-
> > > Hi Damyan,
> > >
> > > great that you are packaging firebird4.0 for Debian. Volker and I have tried
> > > to build the source from
> > > https://salsa.debian.org/firebird-team/firebird4.0/
> > > with our mini-buildd on Debian Sid
> > > at Tue, 17 Aug 2021 10:32:13 +0000
> > > and it failed with a strange linker error:
> > >
> > > /usr/bin/ld: g++  -g -O2
> > > -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
> > > -Werror=format-security -DUCHAR_TYPE=uint16_t -fno-lifetime-dse
> > > -fno-strict-aliasing -Wl,-z,relro -Wl,-z,now -Wl,-z,relro -Wl,-z,now
> > > -pthread    -Wl,--version-script,empty.vers
> > > /<<PKGBUILDDIR>>/temp/Release/alice/alice.o
> > > /<<PKGBUILDDIR>>/temp/Release/alice/alice_meta.o
> > > /<<PKGBUILDDIR>>/temp/Release/alice/exe.o
> > > /<<PKGBUILDDIR>>/temp/Release/alice/tdr.o
> > > /<<PKGBUILDDIR>>/temp/Release/alice/main/aliceMain.o
> > > /<<PKGBUILDDIR>>/temp/Release/common.a -o
> > > /<<PKGBUILDDIR>>/gen/Release/firebird/bin/gfix
> > > -L/<<PKGBUILDDIR>>/gen/Release/firebird/lib -lfbclient -ltommath -ltomcrypt
> > > -latomic -lm -ldl   -ldecFloat -lre2
> > > /<<PKGBUILDDIR>>/temp/Release/common.a(SimilarToRegex.o): in function
> > > `Firebird::SimilarToRegex::matches(char const*, unsigned int,
> > > Firebird::Array<Firebird::SimilarToRegex::MatchPos,
> > > Firebird::EmptyStorage<Firebird::SimilarToRegex::MatchPos> >*)':
> > > ./gen/./src/common/SimilarToRegex.cpp:858: undefined reference to `re2::RE2::Arg::parse_stringpiece(char const*, unsigned long, void*)'
> >
> > Thanks for the notice.
> >
> > This is probably related to the new g++ in sid. Trying the build today
> > failed even earlier, perhaps due to the new autotools. So this needs
> > more work.

Btw, it (commit 25af992) fails on bullseye the same way, but it succeeds 
on buster.

> Simply letting debhelper do the autoreconf seems to work and the build 
> completes, no linker errors. This is in an up to date sid sbuild chroot.

I tried this (commit f89edee), but it fails again on sid with the same 
libre2 linker error.

I think that's a clash between bundled libre2 and system libre2. Although 
configure is called with --with-system-re2, the flags contain 
-I/<<PKGBUILDDIR>>/extern/re2, and I guess that's the problem. Maybe 
debian/patches/out/system-re2.patch needs a second look at.

Viele Grüße,
Frank