[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#964905: [Martin Tournoij] Re: GoatCounter port



Some more information about Debian packaging, from upstream.
-- 
For once you have tasted flight,
You will walk the earth with your eyes turned skyward;
For there you have been,
And there you long to return.
                        - Leonardo da Vinci


--- Begin Message ---
Also, I looked at your Debian package (things were getting very off-topic on
the Docker issue 😅) and I see you're building with Go 1.11, at least that's
that the path "/usr/lib/go-1.11" suggests.

Go 1.11 won't work correct since it requires some features in Go 1.13 or
newer. It looks like in GoatCounter 1.3 it'll kinda-work since it doesn't
use any of the new functions so no compile errors, but it does use:

    return errors.Errorf("salt.Refresh: %w", err)

That "%w" will only work with Go 1.13 or newer, with older versions you'll
get some sort of inline error telling you that %w isn't recognized and that
there's extra data (i.e. the errors will look weird/wrong).

Also, the  reason you're getting this error:

	anarcat@emma:dist(master)$ dh-make-golang estimate zgo.at/goatcounter
	go get: 175.92 MiBpackage zgo.at/goatcounter/cmd/check
		imports honnef.co/go/tools/code: cannot find package "honnef.co/go/tools/code" in any of:
		/usr/lib/go-1.11/src/honnef.co/go/tools/code (from $GOROOT)
		/tmp/dh-make-golang182190041/src/honnef.co/go/tools/code (from $GOPATH)

Is because it's using the latest master of the "honnef.co/go/tools"
dependency, rather than the 2020.1.4 tag in the go.mod file.

It's not really critical, as it's just the linter tool that goatcounter
uses. You don't need to build it.

--- End Message ---

Reply to: