Quoting Ricardo Ribalda Delgado (2020-06-04 19:53:10) > I have just updated my salsa to 2.2.0 > https://salsa.debian.org/ribalda-guest/ugrep/-/tree/debian In case > that you want to give it a try. Great! A few remarks about the packaging: The autopkgtest failed: upstream-test-suite FAIL stderr: configure.ac:31: installing './ar-lib' Seems you need to add the allow-stderr restriction - more info here: https://salsa.debian.org/ci-team/autopkgtest/raw/master/doc/README.package-tests.rst Related to autopkgtest I (just earlier today in fact) noticed the "build-needed" restriction which seems perfectly suitable for the kind of test you've setup. The package short description is wrongly used as a first line of the long description - check Debian Policy § 5.6.13 for the details on that. I also would have expected libreflex to be built as a shared library for reuse by other future packages besides ugrep - but perhaps you've discussed that with Zumbi already and there is some sensible reason for embedding the library with ugrep. Are you aware that you can use wildcards with lintian overrides? Seems your 18 almost identical overrides can be shrunk to just one line. And while at it, please consider adding a comment describing why those warnings are overridden (it is easier to agree or disagree with your reasoning without first reading your mind :-) ). You've listed only copyright and licensing for main upstream author and yourself - but there are also (at least) some autotools-originated files licensed as Expat, FSFAP, FSFUL, FSFULLR, GPL-2+, and GPL-3+. Possibly you are already aware and consider those irrelevant to track in debian/copyright, but mentioning in case the omission wasn't deliberate, as I suspect ftpmaster might disagree with doing that. If interested, then I can guide you in using licensecheck to check that (and keep track of changes for later updates). Thanks a lot for packaging ugrep. I hadn't heard about it before I saw your ITP, and it looks like an amazing tool, that I will sure spend some time getting familiar with now. - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private
Attachment:
signature.asc
Description: signature