Bug#888705: abseil-cpp packaging
On Tue, May 19, 2020 at 6:28 PM Benjamin Barenblat <bbaren@debian.org> wrote:
> Okay, we’re all set. I’ve pushed my work to
> https://salsa.debian.org/debian/abseil, and both command-line linking
> and CMake integration work. Comments and suggestions are welcome – if I
> don’t hear anything in the next day or two, I’ll go ahead and upload to
> NEW.
Just some points that come to mind. Backport to oldstable will not be
easily possible, but not a problem for me.
File 'control' might be better autogenerated with the ABI string
easily changeable, but well 'sed s///' works as well. Doesn't build
with GCC 10 due to symbol changes.
How do you plan Git tagging? Might be better to prefix current tags
with 'upstream/' and have Debian releases under 'debian/'.
Rules-Requires-Root might be set to 'no' I guess, but that's nitpicking.
Very well done packaging otherwise.
Thanks,
Laszlo/GCS
Reply to: