Bug#955495: ITP: orthanc-python -- Develop plugins for Orthanc using the Python programming language
Dear Alex,
Thanks so much for your careful review of the package!
According to your message, I have applied several fixes to it:
https://salsa.debian.org/med-team/orthanc-python/-/commits/master
if this is a python module then it should follow python guidelines.
The name in this case should be python3-orthanc, see LibraryStyleGuide:
https://wiki.debian.org/Python/LibraryStyleGuide
After building and installing orthanc-python I can't import orthanc from
python3 most likely because python doesn't know where to find it.
By following the python packaging guidelines this problem will be solved.
Actually, this package is *not* a Python module. It is a plugin for the
Orthanc server in order to call Python from Orthanc. In other words,
Orthanc launches the Python interpreter, and the "orthanc" module makes
only sense within Orthanc: Python shouldn't be able to import the
"orthanc" module it outside of Orthanc.
So, my guess is that the package shouldn't be called "python-orthanc" or
"python3-orthanc".
That being said, I have changed the dependency from Python 3 to Python 2
in "d/control", as the "python" token implies the use of Python 2. It
would probably make sense, once the "orthanc-python" package is on its
way, to create a sibling "orthanc-python3" package that would use Python 3.
I'd remove Resources/Builders/ via files-excluded in d/copyright since
these files are not relevant for Debian as far as I see.
Done.
There is no need in empty d/patches/
Indeed: Removed.
d/watch, is there need for +dfsg suffix ? If I run uscan
--force-download it downloads and repacks tarball without dfsg suffix.
Indeed, the "dfsg" is not relevant. As there is now a "Files-Excluded",
I have however used the "ds" to emphasizes the removal of the source
directory "Resources/Builders".
Some files have trailing white space, which is a bit annoying, but this
is already nitpicking :)
- d/control
- d/copyright
Nice catch :-) Fixed.
Please let me know if other problems prevent the upload to the NEW queue.
Thanks again for your help,
Sébastien-
Reply to: