[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#945230: Packaging ready to be reviewed and sponsored



[snip]

> I reviewed your package and I'd like to ask you to fix your pristine-tar
> branch. As you can see here [1], the name of the files doesn't match the
> source package name (mdectl != mdevctl)

Arr different reviewers raced each other on this coming in on
IRC/MRs/mail. Yeah I fixed up my filename but forgot about the
pristine-tar branch for the same
Done - pristine-tar&upstream branches are good now and everything
rebased accordingly.

> besides that the version in
> your d/changelog is 0.50 [2] and in those files we have 0.50.0. I needed
> to fix them manually to be able to successfully generate the upstream
> tarball.

It is 0.50 intentionally as another reviewer pointed out that upstream
has only two digits of versioning at the moment.
The mismatches are now fixed by the refresh of the pristine-tar branch
you asked about above - there it is 0.50 as well now.

> Apart from that it looks good to me.
>
> If you want to move your git repo into 'debian' group in salsa [3] let
> me know and I can create the project and grant you the appropriated
> permissions. Usually I prefer to host non team maintained packages repos
> in this group.

Yeah as I said I don't mind the place, if that is a good/common one
that will be fine for me.

After discussion on IRC we created this repository and I pushed things there.

I have an update to d/control to reflect that in git, but not yet
uploaded waiting for the ftpmasters review on the initial upload to
have their needs be reflected in that upload as well.

> Let me know when you have the pristine-tar branch fixed and I'll be
> happy to sponsor this package for you :)

I got further reviewers and sponsors in the meantime (thanks to all of
you) and it is already uploaded - no further sponsoring needed right
now.

[snip]


Reply to: