Am Sonntag, den 07.04.2019, 15:26 +0200 schrieb Stefan Potyra: > Hi Bruno, > > On Sat, Apr 06, 2019 at 04:56:29AM +0200, Bruno Kleinert wrote: > > Hi Stefan, > > > > that's great! I offer reviews and will sponsor uploads :) > > cool, thanks for the offer :). > > Preliminary package available: > dget http://potyra.de/dlt-viewer/dlt-viewer_2.18.0+dfsg-1.dsc > > Please give it a thourough review. It's been some time since I last created a > package... > > Cheers, > Stefan. Hi Stefan, I only had minor improvements, see attached debdiff. Those include: * Set debhelper compatibility level by build dependency magic. * Update the .desktop file patch to remove a broken line and add another category for the tool. * Override lintian warning for source tarball repack and provide a rationale. I *think* the "Copyright (c)" part is redundant in debian/copyright and could possibly be removed from lines 27-32. Cheers - Bruno
diff -Nru dlt-viewer-2.18.0+dfsg/debian/compat dlt-viewer-2.18.0+dfsg/debian/compat
--- dlt-viewer-2.18.0+dfsg/debian/compat 2019-04-06 14:15:24.000000000 +0200
+++ dlt-viewer-2.18.0+dfsg/debian/compat 1970-01-01 01:00:00.000000000 +0100
@@ -1 +0,0 @@
-12
diff -Nru dlt-viewer-2.18.0+dfsg/debian/control dlt-viewer-2.18.0+dfsg/debian/control
--- dlt-viewer-2.18.0+dfsg/debian/control 2019-04-07 14:38:26.000000000 +0200
+++ dlt-viewer-2.18.0+dfsg/debian/control 2019-04-07 14:38:26.000000000 +0200
@@ -3,7 +3,7 @@
Priority: optional
Maintainer: Stefan Potyra <stefan@potyra.de>
Uploaders: Bruno "Fuddl" Kleinert <fuddl@debian.org>
-Build-Depends: debhelper (>= 12),
+Build-Depends: debhelper-compat (= 12),
qtbase5-dev,
qtdeclarative5-dev,
libqt5serialport5-dev,
@@ -18,7 +18,7 @@
Depends: ${shlibs:Depends}, ${misc:Depends}
Description: Viewer for GENIVI DLT traces
The Diagnostic Log and Trace Viewer is an application that can send and
- receive control messages to the DLT daemon, e.g. to set individual log
+ receive control messages to the DLT daemon, e.g., to set individual log
levels of applications and contexts or get the list of applications
and contexts registered in the DLT daemon.
@@ -27,7 +27,7 @@
Depends: ${shlibs:Depends}, ${misc:Depends}
Description: Viewer for GENIVI DLT traces - development files
The Diagnostic Log and Trace Viewer is an application that can send and
- receive control messages to the DLT daemon, e.g. to set individual log
+ receive control messages to the DLT daemon, e.g., to set individual log
levels of applications and contexts or get the list of applications
and contexts registered in the DLT daemon.
.
diff -Nru dlt-viewer-2.18.0+dfsg/debian/patches/02_fix_desktop_file.patch dlt-viewer-2.18.0+dfsg/debian/patches/02_fix_desktop_file.patch
--- dlt-viewer-2.18.0+dfsg/debian/patches/02_fix_desktop_file.patch 2019-04-07 14:38:26.000000000 +0200
+++ dlt-viewer-2.18.0+dfsg/debian/patches/02_fix_desktop_file.patch 2019-04-07 14:38:26.000000000 +0200
@@ -3,14 +3,20 @@
Author: Stefan Potyra <stefan@potyra.de>
Forwarded: no
---- dlt-viewer-2.18.0+dfsg.orig/src/dlt_viewer.desktop
-+++ dlt-viewer-2.18.0+dfsg/src/dlt_viewer.desktop
-@@ -3,7 +3,7 @@ Type=Application
+Index: dlt-viewer-2.18.0+dfsg/src/dlt_viewer.desktop
+===================================================================
+--- dlt-viewer-2.18.0+dfsg.orig/src/dlt_viewer.desktop 2019-04-08 19:10:07.038029821 +0200
++++ dlt-viewer-2.18.0+dfsg/src/dlt_viewer.desktop 2019-04-08 19:17:21.299174475 +0200
+@@ -1,9 +1,8 @@
+ [Desktop Entry]
+ Type=Application
Name=DLT Viewer
- Name[xx]=Diagnostic Log and Trace Viewer
- GenericName=DLT Viewer - Diagnostic Log and Trace Viewer needed for devices running DLT daemon
+-Name[xx]=Diagnostic Log and Trace Viewer
+-GenericName=DLT Viewer - Diagnostic Log and Trace Viewer needed for devices running DLT daemon
-Exec=dlt_viewer %u
++GenericName=Diagnostic Log and Trace Viewer needed for devices running DLT daemon
+Exec=dlt-viewer %u
Icon=face-glasses
Terminal=false
- Categories=Qt;KDE;Development;
+-Categories=Qt;KDE;Development;
++Categories=Qt;KDE;Development;System;
diff -Nru dlt-viewer-2.18.0+dfsg/debian/source/lintian-overrides dlt-viewer-2.18.0+dfsg/debian/source/lintian-overrides
--- dlt-viewer-2.18.0+dfsg/debian/source/lintian-overrides 1970-01-01 01:00:00.000000000 +0100
+++ dlt-viewer-2.18.0+dfsg/debian/source/lintian-overrides 2019-04-07 14:38:26.000000000 +0200
@@ -0,0 +1,2 @@
+# Rationale is documented in debian/README.source
+dlt-viewer source: missing-explanation-for-repacked-upstream-tarball
Attachment:
signature.asc
Description: This is a digitally signed message part