Bug#935329: RFP: git-revise -- handy git tool for doing efficient in-memory commit rebases & fixups
Control: tags -1 +pending
On 2019-09-26 19:07:45, Nicolas Schier wrote:
> Hi Antoine,
>
>> [...]
>> Could you hook up the test suite in autopkgtest somehow?
>
> I prepared a debian/tests/control, but upstream's test suite does not
> successfully run on any of my Debian machines, neither when I run 'tox'
> (as suggested in docs/contributing.rst), nor if I call pytest-3
> directly. I contacted upstream, but did not yet get a reply. Thus,
> I'd like to defer enabling the autopkgtest stuff.
If the actual thing does work in Debian, that's fine I guess. :) Funny
how it's sometimes harder to run tests than the actual software...
>> The docbase stuff is usually in HTML, and to make it work you'd need to
>> build it with the Sphinx package, I think. It would be better to split
>> that out in a separate -doc package.
>
> Sounds reasonable to me. I put it on my todo list.
Not a blocker.
[...]
>> Did you audit or review the upstream source?
>
> Finally, yes. I read completely through the git-revise code (but not
> the test suite, yet).
>
> I uploaded the new version to mentors [1] and this time the sources
> should be equivalent to the ones in
>
> https://salsa.debian.org/debian/git-revise -b debian/sid
>
> with the exception of the actual changelog-Release commit (that is only
> in https://salsa.debian.org/nsc-guest/git-revise).
>
> As soon as the package is uploaded one day, I will create these bugs:
>
> - Use upstream's test suite for autopkgtest
> - split-out a git-revise-doc package with HTML docs and proper docbase
> integration
>
> Can you please have a look at the upload, once again?
This all looks good, and I'm uploading the files now. Congratulations!
a.
--
We must shift America from a needs- to a desires-culture. People must
be trained to desire, to want new things, even before the old have
been entirely consumed. Man's desires must overshadow his needs.
- Paul Mazur, Lehman Brothers
Reply to: