[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#825809: unclutter: diff for NMU version 8-21.1



Hi Sean,

Sean Whitton wrote:
> +
> +override_dh_auto_install:
> +

Hmmm, I think that could be avoided.

> +override_dh_installman:
> +	cp unclutter.man debian/tmp/unclutter-classic.man
> +	dh_installman debian/tmp/unclutter-classic.man

Hmmm, this looks rather ugly to me. If we already use dh-exec, we
should use it for that, too, IMHO.

> diff -Nru unclutter-8/debian/unclutter.install unclutter-8/debian/unclutter.install
> --- unclutter-8/debian/unclutter.install	2017-12-30 11:53:06.000000000 -0700
> +++ unclutter-8/debian/unclutter.install	2019-08-31 12:32:55.000000000 -0700
> @@ -1,2 +1,4 @@
> -debian/local/90unclutter	/etc/X11/Xsession.d
> -unclutter			/usr/bin
> +#!/usr/bin/dh-exec
> +
> +debian/local/90unclutter	=> /etc/X11/Xsession.d/90unclutter
> +unclutter			=> /usr/bin/unclutter-classic

I think we'll have some issues if we don't include
/etc/X11/Xsession.d/90unclutter in the alternatives, too:

* Only either unclutter or unclutter-xfixes can ship this file.

* It will operate on whatever is chosen with update-alternatives, but
  only if the package which contains it, is installed, too.

* Installing this file with different names from both packages is no
  option as it would start both programs (and I don't think that's a
  good idea) if both are installed.

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe@debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE


Reply to: