[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#694077: Package review



= debian/changelog

As it's the first upload the only line really needed is:

* Initial release (Closes: #694077)

= debian/patches

Why are you disabling patches? The patch description is not clear
about it. I had to read debian/rules to know why :-)

Try this:

override_dh_auto_test-arch:
<insert tab>    xvfb-run -a -s "-screen 0 1024x768x24 +extension RANDR
+extension RENDER +extension GLX +extension EGL" \
        dh_auto_test --max-parallel=1 --
QT_PLUGIN_PATH=$(CURDIR)/plugins QML2_IMPORT_PATH=$(CURDIR)/qml

The Qt5 version seems to use QML so the above should work. This comes
from qt3d's debian/rules.

After that override the -indep target:

override_dh_auto_test-indep:


And leave no commands in it. This is because this package does not
seems to have testes for arch:all binary packages (I might be wrong
though).

= debian/copyright

Massimo Callegari's copyright should go at least up to 2018:

   2012-2018 Massimo Callegari <massimocallegari@yahoo.it>

You are missing many copyright entries and licenses. Please start with:

grep -iRn copyright *

in the project's root directory. You will find many people nott yest listed.

Feel free to ping me for sponsorship!!!

Lisandro.

-- 
Lisandro Damián Nicanor Pérez Meyer
http://perezmeyer.com.ar/
http://perezmeyer.blogspot.com/


Reply to: