❦ 13 juillet 2019 12:29 -05, Alberto Leiva <ydahhrk@gmail.com>:
>> - d/changelog: do you have any contact with Bjoern Buerger, the
>> original author of the ITP?
>
> We talked up to 2018-05-10.
>
> I sent him another email on 2018-05-28, and then another one two days
> ago. Both of them have gone unanswered as of now.
OK, if he disagrees, he still have a bit of time to make us aware of that.
>> - d/copyright: as upstream, you should either put the expected
>> copyright notice in each source file (as explained in the license) or
>> put it in a LICENSE file. I say that mostly because just the content
>> of COPYING makes it difficult to know if it is licensed as GPL-2 or
>> GPL-2 or a later version. The package may be rejected because of this
>> issue when uploaded to Debian. To not release a new tarball just with
>> that, you can clarify the situation in a "Comment" field.
>
> I have violent feelings about adding a license header to every file in
> the project.
>
> I don't have any problems with releasing another tarball, though. The
> license information is currently in the README, which I just noticed
> is not exported to the tarball, likely because of the .md extension.
> Nice catch.
>
> My plan is to
>
> - Remove the "Legal Stuff" section from the README
> (https://github.com/NICMx/Jool#legal-stuff), move it to a new LICENSE
> file.
> - Patch the README.md export.
>
> You reckon this will be enough?
Yes.
>> - d/jool-dkms.install: this shouldn't be a shell script
>
> What's the alternative? It seems I need a dynamic way to compute the
> version number, or risk borking it in every release.
In fact, I didn't know it was possible to use any shell script!
You could move the content to debian/rules (not tested):
include /usr/share/dpkg/pkg-info.mk
override_dh_install:
dh_install -Njool-dkms
for DIRECTORY in src/common src/mod; do \
for FILE in $$(find $$DIRECTORY -name *.h -o -name *.c -o -name Makefile -o -name Kbuild); do \
dh_install -pjool-dkms $$FILE $$(dirname usr/src/jool-dkms-$(DEB_VERSION_UPSTREAM)/$$FILE); \
done; \
done
But I think, you can also go with:
include /usr/share/dpkg/pkg-info.mk
override_dh_install:
dh_install -Njool-dkms
dh_install -pjool-dkms -X/usr/ -X.o src usr/src/jool-dkms-$(DEB_VERSION_UPSTREAM)
>> or override Lintian for
>> package-supports-alternative-init-but-no-init.d-script with some
>> comment in the override.
>
> I'm not getting that warning. Which version of Lintian are you using?
> I better try to compile that.
lintian 2.16.0. So, it seems to be a pretty recent addition. This
explains why I didn't heard of it until now but I think people will
start complaining about that soon. In the meantime, the strategy to not
ship any service on first upload, then ship them after will make your
life easier. And, you'll have to make another upload shortly after the
being accepted just because we have to do a binary upload on first
upload, then a source upload to be able to migrate to testing (we love
making people's life miserable).
--
F.S. Fitzgerald to Hemingway:
"Ernest, the rich are different from us."
Hemingway:
"Yes. They have more money."
Attachment:
signature.asc
Description: PGP signature