Bug#929405: ITP: pveclib -- power vector library
On Sat, 25 May 2019 15:31:47 -0300 "Gabriel F. T. Gomes" <gabriel@inconstante.net.br> wrote:
>
> As-is sounds good to me. :)
On second thought, I have an usability question for you, which would
also be relevant for other distros that might ship pveclib...
The headers are currently installed under /usr/include/pveclib/ (this
is based on what 'make install' does). Then, users will have to use
'-I/usr/include/pveclib/' on their compilation commands, similarly to
what is suggested in the README page [1] for pveclib.
Wouldn't it be more appropriate to ask users to use:
#include <pveclib/some_header.h>
instead? (and forget about '-I').
But if we do that, all header files in pveclib would have to be patched
so that the files they include also contain 'pveclib/', for instance,
in src/vec_bcd_ppc.h:
-#include <vec_common_ppc.h>
-#include <vec_char_ppc.h>
-#include <vec_int128_ppc.h>
+#include <pveclib/vec_common_ppc.h>
+#include <pveclib/vec_char_ppc.h>
+#include <pveclib/vec_int128_ppc.h>
I submitted a pull request [2] upstream to foster this discussion.
[1] https://github.com/open-power-sdk/pveclib#usage
[2] https://github.com/open-power-sdk/pveclib/pull/71
Reply to: