Bug#859130: Feedback on lina packaging
Hello Albert,
Some feedback on your packaging of lina.
debian/patches/fill-in-library-path
-----------------------------------
It is 400Kb, it has
--- /dev/null
+++ lina-5.3.0/ci86.gnr
@@ -0,0 +1,11435 @@
so it adds a complete new lina-5.3.0/ci86.gnr
the git repo at github has allready an 'ci86.gnr'
So please, pretty please, avoid the re-adding.
debian/patches/fill-in-library-path-2
-------------------------------------
Contains
--- lina-5.3.0.orig/extract/ci86.gnr
+++ lina-5.3.0/extract/ci86.gnr
So there is another 'ci86.gnr', but why?
And where does the 'extract/' directory come from?
( the git repo doesn't have it )
debian/patches/assorted-nitpicks
--------------------------------
Starts with
Description: assorted nitpicks
Fixes minor complaints by lintian, such as
(alledged) spelling error's
wrong file name
wrong license id
spurious white space
None of fixes are in the actual patch.
There is only
--- lina-5.3.0.orig/lina.1
+++ lina-5.3.0/lina.1
@@ -168,5 +168,5 @@ The library has comments but no comprehe
.SH "AUTHOR"
Copyright \(co 2000-2016
Albert van der Horst \fI albert@spenarnc.xs4all.nl\fR.
-\fBciforth\fR is made available under the GNU Public License:
+\fBciforth\fR is made available under the GNU General Public License:
quality, but NO warranty.
Make that change in the upstream code,
so there is a patch less to maintain.
( so there is a patch less to review )
Afterall you are upstream maintainer.
debian/patches/added-makefile
-----------------------------
Starts with
Description: added makefiles to source only package
Version 5.3.0 only exports proper source files, where the makefile
of version 5.3.0 refers to the generic package.
A Makefile is added to build the binary package, and extract.mak
is added to the extract directory.
To me that reads as
Description: added makefiles to source only package
Upstream Makefile is not suitable for a Linux environment
Now here a Makefile only for Debian.
That is wrong, at least it feels wrong to me.
At https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=859130#53
are a 'configure' and a 'Makefile'. Include those files upstream so
each Linux environment can benefit from it.
forth.lab
---------
In the ".orig.tar.xz" is a file 'forth.lab'.
I don't see it in the git repo.
Where does it come from?
debian/watch
------------
There is no debian/watch file, it should.
Yes, as strong as I did express that, so strong is it meant.
.orig.tar.gz
------------
The .orig.tar.gz seems to be handcrafted.
Avoid that.
Surely avoid putting a binary like .tar.gz
in a _text_ version control system.
So far my feedback.
Please keep this bugreport in the loop upon further progress.
Cheers
Geert Stappers
Reply to: